From b2f063590f7e6efa56d23f5d029f64cb0c9b6e97 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timoth=C3=A9e=20Alby?= Date: Thu, 16 Sep 2021 10:47:25 +0200 Subject: [PATCH] Merge pull request #5045 from overleaf/ab-fix-event-property-errors Cleanup event properties flagged in Human37 recommendation GitOrigin-RevId: f09f06b86a38ddb430902ba71df4d1b002eaaec6 --- .../src/Features/Collaborators/CollaboratorsInviteController.js | 1 - services/web/frontend/js/main/new-subscription.js | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/services/web/app/src/Features/Collaborators/CollaboratorsInviteController.js b/services/web/app/src/Features/Collaborators/CollaboratorsInviteController.js index 4c5a2b8d22..cf5bab90e8 100644 --- a/services/web/app/src/Features/Collaborators/CollaboratorsInviteController.js +++ b/services/web/app/src/Features/Collaborators/CollaboratorsInviteController.js @@ -382,7 +382,6 @@ module.exports = CollaboratorsInviteController = { 'project-invite-accept', { projectId, - userId: currentUser._id, } ) if (req.xhr) { diff --git a/services/web/frontend/js/main/new-subscription.js b/services/web/frontend/js/main/new-subscription.js index 07f481e70a..e589709a06 100644 --- a/services/web/frontend/js/main/new-subscription.js +++ b/services/web/frontend/js/main/new-subscription.js @@ -35,7 +35,7 @@ export default App.controller( const currentPlanCode = window.plan_code const planCode = currentPlanCode.replace('collaborator', 'student') eventTracking.sendMB('payment-page-switch-to-student', { - plan: window.plan_code, + plan_code: window.plan_code, }) eventTracking.send( 'subscription-funnel',