From b39cdbc87466acf6234040a59bc087cad74c669b Mon Sep 17 00:00:00 2001 From: Simon Detheridge Date: Wed, 7 Nov 2018 10:21:15 +0000 Subject: [PATCH] Merge pull request #1116 from sharelatex/as-fix-history-error Fix error thrown when viewing history with non-default font size GitOrigin-RevId: f4f561bfe25537663cddf79d1867393bd209dd38 --- .../public/src/ide/editor/directives/aceEditor.js | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/services/web/public/src/ide/editor/directives/aceEditor.js b/services/web/public/src/ide/editor/directives/aceEditor.js index 99f30ae5ff..5434e5ceb6 100644 --- a/services/web/public/src/ide/editor/directives/aceEditor.js +++ b/services/web/public/src/ide/editor/directives/aceEditor.js @@ -762,11 +762,13 @@ define([ return doc.off('change', onChange) } - editor.renderer.on('changeCharacterSize', () => - scope.$apply( - () => (scope.rendererData.lineHeight = editor.renderer.lineHeight) - ) - ) + if (scope.rendererData != null) { + editor.renderer.on('changeCharacterSize', () => { + scope.$apply( + () => (scope.rendererData.lineHeight = editor.renderer.lineHeight) + ) + }) + } scope.$watch('rendererData', function(rendererData) { if (rendererData != null) {