From b3b31fb052052282d5fc5b85e8214b8bbd67391b Mon Sep 17 00:00:00 2001 From: Alf Eaton Date: Mon, 2 Oct 2023 11:24:50 +0100 Subject: [PATCH] [cm6] Match uppercase file extensions in the include autocomplete (#14956) GitOrigin-RevId: eb6898ef031dcc05f9fcb530fd4578ffda234a14 --- .../source-editor/languages/latex/completions/include.ts | 2 +- .../components/codemirror-editor-autocomplete.spec.tsx | 8 ++++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/services/web/frontend/js/features/source-editor/languages/latex/completions/include.ts b/services/web/frontend/js/features/source-editor/languages/latex/completions/include.ts index 0b5d4ad7d6..7de46118e8 100644 --- a/services/web/frontend/js/features/source-editor/languages/latex/completions/include.ts +++ b/services/web/frontend/js/features/source-editor/languages/latex/completions/include.ts @@ -59,7 +59,7 @@ export function buildIncludeCompletions( } // TODO: a better list of graphics extensions? - if (/\.(eps|jpe?g|gif|png|tiff?|pdf|svg)$/.test(path)) { + if (/\.(eps|jpe?g|gif|png|tiff?|pdf|svg)$/i.test(path)) { // path parameter for \includegraphics{path} completions.graphics.push({ type: 'file', diff --git a/services/web/test/frontend/features/source-editor/components/codemirror-editor-autocomplete.spec.tsx b/services/web/test/frontend/features/source-editor/components/codemirror-editor-autocomplete.spec.tsx index 784d0ae1a8..05f68c304c 100644 --- a/services/web/test/frontend/features/source-editor/components/codemirror-editor-autocomplete.spec.tsx +++ b/services/web/test/frontend/features/source-editor/components/codemirror-editor-autocomplete.spec.tsx @@ -54,6 +54,10 @@ describe('autocomplete', { scrollBehavior: false }, function () { _id: 'test-image-file', name: 'frog.jpg', }, + { + _id: 'uppercase-extension-image-file', + name: 'frog.JPG', + }, ], }, ] @@ -191,8 +195,8 @@ describe('autocomplete', { scrollBehavior: false }, function () { .type('{ctrl+ }') cy.findAllByRole('listbox').should('have.length', 1) - cy.findByRole('listbox').contains('frog.jpg').click() - activeEditorLine().should('have.text', '\\includegraphics[]{frog.jpg}') + cy.findByRole('listbox').contains('frog.JPG').click() + activeEditorLine().should('have.text', '\\includegraphics[]{frog.JPG}') }) it('opens autocomplete on begin environment', function () {