From b4dd04737108f357f6089ba15f7a1b1a8ca6d5ab Mon Sep 17 00:00:00 2001 From: Alasdair Smith Date: Wed, 11 Jul 2018 14:08:43 +0100 Subject: [PATCH] Fix unnecessary right marging being applied to review panel when rich text is open --- .../web/public/coffee/ide/editor/directives/aceEditor.coffee | 1 + .../ide/review-panel/controllers/ReviewPanelController.coffee | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/services/web/public/coffee/ide/editor/directives/aceEditor.coffee b/services/web/public/coffee/ide/editor/directives/aceEditor.coffee index 33fac29f32..a78df6a10a 100644 --- a/services/web/public/coffee/ide/editor/directives/aceEditor.coffee +++ b/services/web/public/coffee/ide/editor/directives/aceEditor.coffee @@ -521,6 +521,7 @@ define [ detachFromAce(scope.sharejsDoc) session = editor.getSession() session?.destroy() + scope.eventsBridge.emit "aceScrollbarVisibilityChanged", false, 0 scope.$emit "#{scope.name}:inited", editor diff --git a/services/web/public/coffee/ide/review-panel/controllers/ReviewPanelController.coffee b/services/web/public/coffee/ide/review-panel/controllers/ReviewPanelController.coffee index 430c5cd246..2eabee764c 100644 --- a/services/web/public/coffee/ide/review-panel/controllers/ReviewPanelController.coffee +++ b/services/web/public/coffee/ide/review-panel/controllers/ReviewPanelController.coffee @@ -164,7 +164,7 @@ define [ updateScrollbar() updateScrollbar = () -> - if scrollbar.isVisible and $scope.reviewPanel.subView == $scope.SubViews.CUR_FILE + if scrollbar.isVisible and $scope.reviewPanel.subView == $scope.SubViews.CUR_FILE and !$scope.editor.showRichText $reviewPanelEl.css "right", "#{ scrollbar.scrollbarWidth }px" else $reviewPanelEl.css "right", "0"