From b5d2122f05045c76a580343bdcac9c030c88f4c2 Mon Sep 17 00:00:00 2001
From: Tim Alby <timothee.alby@gmail.com>
Date: Fri, 7 Jan 2022 11:47:08 +0100
Subject: [PATCH] decaf cleanup: remove unnecessary callback fallbacks

GitOrigin-RevId: a6b347e121a30221a305116327e42ad070e81977
---
 .../app/js/Features/Messages/MessageManager.js | 18 ------------------
 .../app/js/Features/Threads/ThreadManager.js   | 15 ---------------
 .../chat/test/acceptance/js/helpers/ChatApp.js |  3 ---
 3 files changed, 36 deletions(-)

diff --git a/services/chat/app/js/Features/Messages/MessageManager.js b/services/chat/app/js/Features/Messages/MessageManager.js
index dc3abc7699..c6a72b4bc5 100644
--- a/services/chat/app/js/Features/Messages/MessageManager.js
+++ b/services/chat/app/js/Features/Messages/MessageManager.js
@@ -5,9 +5,6 @@ const logger = require('@overleaf/logger')
 
 module.exports = MessageManager = {
   createMessage(roomId, userId, content, timestamp, callback) {
-    if (!callback) {
-      callback = function () {}
-    }
     let newMessageOpts = {
       content,
       room_id: roomId,
@@ -25,9 +22,6 @@ module.exports = MessageManager = {
   },
 
   getMessages(roomId, limit, before, callback) {
-    if (!callback) {
-      callback = function () {}
-    }
     let query = { room_id: roomId }
     if (before) {
       query.timestamp = { $lt: before }
@@ -41,9 +35,6 @@ module.exports = MessageManager = {
   },
 
   findAllMessagesInRooms(roomIds, callback) {
-    if (!callback) {
-      callback = function () {}
-    }
     db.messages
       .find({
         room_id: { $in: roomIds },
@@ -52,9 +43,6 @@ module.exports = MessageManager = {
   },
 
   deleteAllMessagesInRoom(roomId, callback) {
-    if (!callback) {
-      callback = function () {}
-    }
     db.messages.deleteMany(
       {
         room_id: roomId,
@@ -64,9 +52,6 @@ module.exports = MessageManager = {
   },
 
   updateMessage(roomId, messageId, content, timestamp, callback) {
-    if (!callback) {
-      callback = function () {}
-    }
     const query = this._ensureIdsAreObjectIds({
       _id: messageId,
       room_id: roomId,
@@ -84,9 +69,6 @@ module.exports = MessageManager = {
   },
 
   deleteMessage(roomId, messageId, callback) {
-    if (!callback) {
-      callback = function () {}
-    }
     const query = this._ensureIdsAreObjectIds({
       _id: messageId,
       room_id: roomId,
diff --git a/services/chat/app/js/Features/Threads/ThreadManager.js b/services/chat/app/js/Features/Threads/ThreadManager.js
index 7f933e5074..e9089c63c7 100644
--- a/services/chat/app/js/Features/Threads/ThreadManager.js
+++ b/services/chat/app/js/Features/Threads/ThreadManager.js
@@ -8,9 +8,6 @@ module.exports = ThreadManager = {
 
   findOrCreateThread(projectId, threadId, callback) {
     let query, update
-    if (!callback) {
-      callback = function () {}
-    }
     projectId = ObjectId(projectId.toString())
     if (threadId !== ThreadManager.GLOBAL_THREAD) {
       threadId = ObjectId(threadId.toString())
@@ -49,9 +46,6 @@ module.exports = ThreadManager = {
   },
 
   findAllThreadRooms(projectId, callback) {
-    if (!callback) {
-      callback = function () {}
-    }
     db.rooms
       .find(
         {
@@ -67,9 +61,6 @@ module.exports = ThreadManager = {
   },
 
   resolveThread(projectId, threadId, userId, callback) {
-    if (!callback) {
-      callback = function () {}
-    }
     db.rooms.updateOne(
       {
         project_id: ObjectId(projectId.toString()),
@@ -88,9 +79,6 @@ module.exports = ThreadManager = {
   },
 
   reopenThread(projectId, threadId, callback) {
-    if (!callback) {
-      callback = function () {}
-    }
     db.rooms.updateOne(
       {
         project_id: ObjectId(projectId.toString()),
@@ -106,9 +94,6 @@ module.exports = ThreadManager = {
   },
 
   deleteThread(projectId, threadId, callback) {
-    if (!callback) {
-      callback = function () {}
-    }
     this.findOrCreateThread(projectId, threadId, function (error, room) {
       if (error) {
         return callback(error)
diff --git a/services/chat/test/acceptance/js/helpers/ChatApp.js b/services/chat/test/acceptance/js/helpers/ChatApp.js
index 66176b5bf1..810bc8f6f6 100644
--- a/services/chat/test/acceptance/js/helpers/ChatApp.js
+++ b/services/chat/test/acceptance/js/helpers/ChatApp.js
@@ -6,9 +6,6 @@ module.exports = {
   initing: false,
   callbacks: [],
   ensureRunning(callback) {
-    if (!callback) {
-      callback = function () {}
-    }
     if (this.running) {
       return callback()
     } else if (this.initing) {