agw/overleaf-cep
1
0
Fork 0
mirror of https://github.com/yu-i-i/overleaf-cep.git synced 2026-11-15 06:33:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #295 from sharelatex/msw-history-failure

Browse Source 
Bail out if history API request fails
This commit is contained in:
Shane Kilkelly
2018-02-01 12:31:30 +00:00
committed by GitHub
parent b7226e6985 9303969d7b
commit ba31df3dae
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/web/app/coffee/Features/History/HistoryController.coffee
+8 -3
View File
@@ -46,9 +46,14 @@ module.exports = HistoryController =
"X-User-Id": user_id "X-User-Id": user_id
}, (error, response, body) -> }, (error, response, body) ->
return next(error) if error? return next(error) if error?
HistoryManager.injectUserDetails body, (error, data) -> if 200 <= res.statusCode < 300
return next(error) if error? HistoryManager.injectUserDetails body, (error, data) ->
res.json data return next(error) if error?
res.json data
else
error = new Error("history api responded with non-success code: #{res.statusCode}")
logger.error err: error, user_id: user_id, "error proxying request to history api"
next(error)
buildHistoryServiceUrl: (useProjectHistory) -> buildHistoryServiceUrl: (useProjectHistory) ->
# choose a history service, either document-level (trackchanges) # choose a history service, either document-level (trackchanges)