Cleanup AiErrorAssistant todos post plans changes (#35067)

* feat: cleaning up ai quota leftovers

fix: removing more straggler invos

* fix: featureUpdater still need analyticsId in the user projection

* feat: updating cypress tests to also check for fair usage text

GitOrigin-RevId: 09c1167106c144084c111beea56867f6aa4a0906

services/web/test/unit/src/Institutions/InstitutionsFeatures.test.mjs

@@ -72,14 +72,12 @@ describe('InstitutionsFeatures', function () {
       features: {
         institution: 'all',
         aiUsageQuota: 'unlimited',
-        aiErrorAssistant: true,
       },
     }
     ctx.testFeaturesWithNoAddon = {
       features: {
         institution: 'all',
         aiUsageQuota: 'basic',
-        aiErrorAssistant: false,
       },
     }
   })

services/web/test/unit/src/Subscription/FeaturesUpdater.test.mjs

@@ -388,7 +388,6 @@ describe('FeaturesUpdater', function () {
         expect(features).to.deep.equal({
           default: 'features',
           individual: 'features',
-          aiErrorAssistant: true,
           aiUsageQuota: 'unlimited',
         })
       })
@@ -407,7 +406,6 @@ describe('FeaturesUpdater', function () {
         )
         expect(features).to.deep.equal({
           default: 'features',
-          aiErrorAssistant: true,
           aiUsageQuota: 'unlimited',
         })
       })

services/web/test/unit/src/infrastructure/WorkbenchRateLimiter.sequential.test.mjs

@@ -65,9 +65,6 @@ describe('WorkbenchRateLimiter', function () {
         featureFlagEnabledForMongoUser: sinon.stub().resolves(true),
       },
     }
-    ctx.SplitTestHandler.promises.getAssignmentForUser
-      .withArgs(ctx.alphaUserId, 'ai-workbench-release')
-      .resolves({ variant: 'enabled' })
 
     vi.doMock('../../../../app/src/infrastructure/mongodb', () => ({
       ObjectId,