From bb031c8b3b4e80a1d2c17902ae25caa3549545e9 Mon Sep 17 00:00:00 2001 From: Jimmy Domagala-Tang Date: Mon, 3 Feb 2025 11:32:46 -0500 Subject: [PATCH] Merge pull request #23281 from overleaf/jdt-opp-prompts-teardown Opportunistic prompts teardown GitOrigin-RevId: ccca9b043dce9abc5719371c3adcdf41ec6510c3 --- .../src/Features/Project/ProjectController.js | 1 - services/web/config/settings.defaults.js | 2 -- .../web/frontend/extracted-translations.json | 3 -- .../modes/file-tree-create-new-doc.jsx | 8 ----- .../components/source-editor.tsx | 11 +------ .../web/frontend/stylesheets/main-style.less | 1 - .../modules/third-party-references.less | 29 ------------------- services/web/locales/en.json | 3 -- .../book-illlustration.svg | 7 ----- 9 files changed, 1 insertion(+), 64 deletions(-) delete mode 100644 services/web/frontend/stylesheets/modules/third-party-references.less delete mode 100644 services/web/public/img/third-party-references/book-illlustration.svg diff --git a/services/web/app/src/Features/Project/ProjectController.js b/services/web/app/src/Features/Project/ProjectController.js index 5cd77d432e..f401898a12 100644 --- a/services/web/app/src/Features/Project/ProjectController.js +++ b/services/web/app/src/Features/Project/ProjectController.js @@ -331,7 +331,6 @@ const _ProjectController = { } const splitTests = [ - !anonymous && 'bib-file-tpr-prompt', 'compile-log-events', 'external-socket-heartbeat', 'full-project-search', diff --git a/services/web/config/settings.defaults.js b/services/web/config/settings.defaults.js index c1dd664245..d74bd88b08 100644 --- a/services/web/config/settings.defaults.js +++ b/services/web/config/settings.defaults.js @@ -950,7 +950,6 @@ module.exports = { tprFileViewRefreshError: [], tprFileViewRefreshButton: [], tprFileViewNotOriginalImporter: [], - newFilePromotions: [], contactUsModal: [], editorToolbarButtons: [], sourceEditorExtensions: [], @@ -962,7 +961,6 @@ module.exports = { sourceEditorCompletionSources: [], sourceEditorSymbolPalette: [], sourceEditorToolbarComponents: [], - editorPromotions: [], langFeedbackLinkingWidgets: [], labsExperiments: [], integrationLinkingWidgets: [], diff --git a/services/web/frontend/extracted-translations.json b/services/web/frontend/extracted-translations.json index 9f04b5a38d..243fabf537 100644 --- a/services/web/frontend/extracted-translations.json +++ b/services/web/frontend/extracted-translations.json @@ -90,7 +90,6 @@ "add_your_first_group_member_now": "", "added_by_on": "", "adding": "", - "adding_a_bibliography": "", "additional_certificate": "", "additional_licenses": "", "address_line_1": "", @@ -164,7 +163,6 @@ "beta_program_already_participating": "", "beta_program_benefits": "", "beta_program_not_participating": "", - "better_bibliographies": "", "billed_yearly": "", "binary_history_error": "", "blank_project": "", @@ -432,7 +430,6 @@ "duplicate_file": "", "duplicate_projects": "", "each_user_will_have_access_to": "", - "easily_import_and_sync_your_references": "", "easily_manage_your_project_files_everywhere": "", "edit": "", "edit_comment_error_message": "", diff --git a/services/web/frontend/js/features/file-tree/components/file-tree-create/modes/file-tree-create-new-doc.jsx b/services/web/frontend/js/features/file-tree/components/file-tree-create/modes/file-tree-create-new-doc.jsx index 0f11ef1761..2d471a741c 100644 --- a/services/web/frontend/js/features/file-tree/components/file-tree-create/modes/file-tree-create-new-doc.jsx +++ b/services/web/frontend/js/features/file-tree/components/file-tree-create/modes/file-tree-create-new-doc.jsx @@ -5,9 +5,6 @@ import { useFileTreeCreateName } from '../../../contexts/file-tree-create-name' import { useFileTreeCreateForm } from '../../../contexts/file-tree-create-form' import * as eventTracking from '../../../../../infrastructure/event-tracking' import ErrorMessage from '../error-message' -import importOverleafModules from '../../../../../../macros/import-overleaf-module.macro' - -const newFilePromotionComponents = importOverleafModules('newFilePromotions') export default function FileTreeCreateNewDoc() { const { name, validName } = useFileTreeCreateName() @@ -36,11 +33,6 @@ export default function FileTreeCreateNewDoc() {
{error && } - {newFilePromotionComponents.map( - ({ import: { default: Component }, path }) => ( - - ) - )} ) } diff --git a/services/web/frontend/js/features/source-editor/components/source-editor.tsx b/services/web/frontend/js/features/source-editor/components/source-editor.tsx index 40786a2bc2..d71f896687 100644 --- a/services/web/frontend/js/features/source-editor/components/source-editor.tsx +++ b/services/web/frontend/js/features/source-editor/components/source-editor.tsx @@ -1,13 +1,7 @@ -import { lazy, memo, Suspense, ElementType } from 'react' +import { lazy, memo, Suspense } from 'react' import { FullSizeLoadingSpinner } from '../../../shared/components/loading-spinner' import withErrorBoundary from '../../../infrastructure/error-boundary' import { ErrorBoundaryFallback } from '../../../shared/components/error-boundary-fallback' -import importOverleafModules from '../../../../macros/import-overleaf-module.macro' - -const editorPromotions = importOverleafModules('editorPromotions') as { - import: { default: ElementType } - path: string -}[] const CodeMirrorEditor = lazy( () => @@ -17,9 +11,6 @@ const CodeMirrorEditor = lazy( function SourceEditor() { return ( }> - {editorPromotions.map(({ import: { default: Component }, path }) => ( - - ))} ) diff --git a/services/web/frontend/stylesheets/main-style.less b/services/web/frontend/stylesheets/main-style.less index d1ac2b1945..ae118aa3f4 100644 --- a/services/web/frontend/stylesheets/main-style.less +++ b/services/web/frontend/stylesheets/main-style.less @@ -155,5 +155,4 @@ @import 'modules/group-settings.less'; @import 'modules/onboarding.less'; @import 'modules/writefull.less'; -@import 'modules/third-party-references.less'; @import 'modules/labs.less'; diff --git a/services/web/frontend/stylesheets/modules/third-party-references.less b/services/web/frontend/stylesheets/modules/third-party-references.less deleted file mode 100644 index ec44a7d8c6..0000000000 --- a/services/web/frontend/stylesheets/modules/third-party-references.less +++ /dev/null @@ -1,29 +0,0 @@ -/* Animation keyframes */ -@keyframes slide-in { - 0% { - transform: translateY(25%); - opacity: 0; - bottom: 12px; - } - 100% { - transform: translateY(0); - opacity: 1; - bottom: 16px; - } -} - -.fade-slide-in { - opacity: 0; - transition: opacity 0.3s ease; /* Smooth opacity transition */ - animation: slide-in 0.3s ease-in-out forwards; - animation-delay: 300ms; -} - -.tpr-editor-prompt-container { - position: absolute; - z-index: 1; - bottom: 16px; - right: 16px; - width: 90%; - max-width: @popover-dark-max-width; -} diff --git a/services/web/locales/en.json b/services/web/locales/en.json index d880d353dc..f69f4ff01d 100644 --- a/services/web/locales/en.json +++ b/services/web/locales/en.json @@ -104,7 +104,6 @@ "added": "added", "added_by_on": "Added by __name__ on __date__", "adding": "Adding", - "adding_a_bibliography": "Adding a bibliography?", "additional_certificate": "Additional certificate", "additional_licenses": "Your subscription includes <0>__additionalLicenses__ additional license(s) for a total of <1>__totalLicenses__ licenses.", "address": "Address", @@ -215,7 +214,6 @@ "beta_program_not_participating": "You are not enrolled in the Beta Program", "beta_program_opt_in_action": "Opt-In to Beta Program", "beta_program_opt_out_action": "Opt-Out of Beta Program", - "better_bibliographies": "Better bibliographies", "bibliographies": "Bibliographies", "billed_annually": "billed annually", "billed_yearly": "billed yearly", @@ -568,7 +566,6 @@ "duplicate_file": "Duplicate File", "duplicate_projects": "This user has projects with duplicate names", "each_user_will_have_access_to": "Each user will have access to", - "easily_import_and_sync_your_references": "Easily import and sync your references from Zotero or Mendeley when you upgrade your Overleaf plan.", "easily_manage_your_project_files_everywhere": "Easily manage your project files, everywhere", "easy_collaboration_for_students": "Easy collaboration for students. Supports longer or more complex projects.", "edit": "Edit", diff --git a/services/web/public/img/third-party-references/book-illlustration.svg b/services/web/public/img/third-party-references/book-illlustration.svg deleted file mode 100644 index e79278cf9a..0000000000 --- a/services/web/public/img/third-party-references/book-illlustration.svg +++ /dev/null @@ -1,7 +0,0 @@ - - - - - - -