From bb5b9afd0ef4e9ce5b2fec2af51f02bc8d6745da Mon Sep 17 00:00:00 2001 From: Antoine Clausse Date: Fri, 4 Jul 2025 12:31:46 +0200 Subject: [PATCH] [web] Define `loadPropensityScript` before use (#26813) This prevents the bug "ReferenceError: Cannot access uninitialized variable" for users who don't have `window.requestIdleCallback`. Fixes https://overleaf.sentry.io/issues/6724866295 GitOrigin-RevId: 129dcb72f24dc901ad600253bab7c58673e44321 --- .../web/frontend/js/infrastructure/tracking-propensity.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/services/web/frontend/js/infrastructure/tracking-propensity.ts b/services/web/frontend/js/infrastructure/tracking-propensity.ts index 0392995140..586f00b1bd 100644 --- a/services/web/frontend/js/infrastructure/tracking-propensity.ts +++ b/services/web/frontend/js/infrastructure/tracking-propensity.ts @@ -6,10 +6,6 @@ import { const { propensityId } = getMeta('ol-ExposedSettings') -if (propensityId) { - createTrackingLoader(() => loadPropensityScript(propensityId), 'Propensity') -} - const loadPropensityScript = (id: string) => { insertScript({ src: 'https://cdn.propensity.com/propensity/propensity_analytics.js', @@ -21,3 +17,7 @@ const loadPropensityScript = (id: string) => { }, }) } + +if (propensityId) { + createTrackingLoader(() => loadPropensityScript(propensityId), 'Propensity') +}