From bb760a3ee28a3be05fc30e86b898f938b30fd5e1 Mon Sep 17 00:00:00 2001 From: Alexandre Bourdin Date: Fri, 11 Jun 2021 12:18:43 +0200 Subject: [PATCH] Merge pull request #4186 from overleaf/ab-expired-sub-plan-code-prop Keep subscription plan code user property when a subscription expires GitOrigin-RevId: 195bfa440dc3fb020f4cbefe44f87bc975aade70 --- .../app/src/Features/Subscription/RecurlyEventHandler.js | 2 +- .../test/unit/src/Subscription/RecurlyEventHandlerTests.js | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/services/web/app/src/Features/Subscription/RecurlyEventHandler.js b/services/web/app/src/Features/Subscription/RecurlyEventHandler.js index 3b0b2c5826..a5780440ab 100644 --- a/services/web/app/src/Features/Subscription/RecurlyEventHandler.js +++ b/services/web/app/src/Features/Subscription/RecurlyEventHandler.js @@ -78,7 +78,7 @@ function _sendSubscriptionExpiredEvent(eventData) { quantity, is_trial: isTrial, }) - AnalyticsManager.setUserProperty(userId, 'subscription-plan-code', null) + AnalyticsManager.setUserProperty(userId, 'subscription-plan-code', planCode) AnalyticsManager.setUserProperty(userId, 'subscription-state', state) AnalyticsManager.setUserProperty(userId, 'subscription-is-trial', isTrial) } diff --git a/services/web/test/unit/src/Subscription/RecurlyEventHandlerTests.js b/services/web/test/unit/src/Subscription/RecurlyEventHandlerTests.js index c0126059d7..5a0d91a7c9 100644 --- a/services/web/test/unit/src/Subscription/RecurlyEventHandlerTests.js +++ b/services/web/test/unit/src/Subscription/RecurlyEventHandlerTests.js @@ -188,6 +188,12 @@ describe('RecurlyEventHandler', function () { is_trial: true, } ) + sinon.assert.calledWith( + this.AnalyticsManager.setUserProperty, + this.userId, + 'subscription-plan-code', + this.planCode + ) sinon.assert.calledWith( this.AnalyticsManager.setUserProperty, this.userId,