From bd476e7cb16e2f93dfe18d6c7d73d9cdaaef3eb7 Mon Sep 17 00:00:00 2001 From: Alf Eaton Date: Fri, 8 Oct 2021 10:25:13 +0100 Subject: [PATCH] Fail tests when context propTypes validation fails (#5323) * Fail test when context proptypes validation fails * Remove isRequired from context propTypes validation GitOrigin-RevId: c6da5f93672434c0d80be3f659c1fc15dc3dab1f --- .../js/features/file-view/components/file-view-header.js | 2 +- services/web/test/frontend/prop-types.test.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/services/web/frontend/js/features/file-view/components/file-view-header.js b/services/web/frontend/js/features/file-view/components/file-view-header.js index 88612d4f75..a01c73c797 100644 --- a/services/web/frontend/js/features/file-view/components/file-view-header.js +++ b/services/web/frontend/js/features/file-view/components/file-view-header.js @@ -37,7 +37,7 @@ export default function FileViewHeader({ file, storeReferencesKeys }) { _id: PropTypes.string.isRequired, }) const { permissionsLevel } = useEditorContext({ - permissionsLevel: PropTypes.string.isRequired, + permissionsLevel: PropTypes.string, }) const { t } = useTranslation() diff --git a/services/web/test/frontend/prop-types.test.js b/services/web/test/frontend/prop-types.test.js index 3927739d36..8e4b148410 100644 --- a/services/web/test/frontend/prop-types.test.js +++ b/services/web/test/frontend/prop-types.test.js @@ -15,7 +15,7 @@ before(function () { originalConsoleError(message, ...args) // Check if the error is from prop-types - if (/Failed prop type/.test(message)) { + if (/Failed (prop|data) type/.test(message)) { // Throw an error, causing the test to fail throw new Error(message) }