From bfd9ab6b8f465a117e164499af63e6e9749642da Mon Sep 17 00:00:00 2001 From: Eric Mc Sween <5454374+emcsween@users.noreply.github.com> Date: Mon, 7 Apr 2025 10:05:56 -0400 Subject: [PATCH] Merge pull request #24604 from overleaf/em-docstore-errors Downgrade 4xx errors in docstore GitOrigin-RevId: ec6c73b4222876e6f58690779571e2e42106c36b --- services/docstore/app.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/services/docstore/app.js b/services/docstore/app.js index b4a26fc24a..76659e8411 100644 --- a/services/docstore/app.js +++ b/services/docstore/app.js @@ -88,14 +88,17 @@ app.get('/status', (req, res) => res.send('docstore is alive')) app.use(handleValidationErrors()) app.use(function (error, req, res, next) { - logger.error({ err: error, req }, 'request errored') if (error instanceof Errors.NotFoundError) { + logger.warn({ req }, 'not found') res.sendStatus(404) } else if (error instanceof Errors.DocModifiedError) { + logger.warn({ req }, 'conflict: doc modified') res.sendStatus(409) } else if (error instanceof Errors.DocVersionDecrementedError) { + logger.warn({ req }, 'conflict: doc version decremented') res.sendStatus(409) } else { + logger.error({ err: error, req }, 'request errored') res.status(500).send('Oops, something went wrong') } })