From bfe06015c89f0c23197fb63642a249c8c568512b Mon Sep 17 00:00:00 2001 From: Jessica Lawshe Date: Thu, 18 Jun 2020 09:04:38 -0500 Subject: [PATCH] Merge pull request #2913 from overleaf/jel-cms-fields-check Add fields check for CMS images GitOrigin-RevId: 53d525ea9861cb8d025920c535054ced6886ca72 --- services/web/app/views/_metadata.pug | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/services/web/app/views/_metadata.pug b/services/web/app/views/_metadata.pug index e57d8969cf..73b6d33bf2 100644 --- a/services/web/app/views/_metadata.pug +++ b/services/web/app/views/_metadata.pug @@ -24,7 +24,7 @@ meta(itemprop="description", content=translate("site_description")) //- Image --if (metadata && metadata.image) +-if (metadata && metadata.image && metadata.image.fields) //- from the CMS meta(itemprop="image", content=metadata.image.fields.file.url) meta(name="image", content=metadata.image.fields.file.url) @@ -59,7 +59,7 @@ meta(name="twitter:card", content=metadata && metadata.twitterCardType ? metadat meta(name="twitter:description", content=metadata.twitterDescription) - else meta(name="twitter:description", content=translate("site_description")) --if (metadata && metadata.twitterImage) +-if (metadata && metadata.twitterImage && metadata.twitterImage.fields) //- from the CMS meta(name="twitter:image", content=metadata.twitterImage.fields.file.url) meta(name="twitter:image:alt", content=metadata.twitterImage.fields.title) @@ -80,7 +80,7 @@ meta(name="twitter:card", content=metadata && metadata.twitterCardType ? metadat -else meta(property="og:description", content=translate("site_description")) --if (metadata && metadata.openGraphImage) +-if (metadata && metadata.openGraphImage && metadata.openGraphImage.fields) //- from the CMS meta(property="og:image", content=metadata.openGraphImage.fields.file.url) -else if (settings.overleaf)