From c10b95ae067eaad1dfbaef032be81ade286ef349 Mon Sep 17 00:00:00 2001 From: Mathias Jakobsen Date: Mon, 7 Jul 2025 12:13:04 +0100 Subject: [PATCH] Merge pull request #26757 from overleaf/mj-papers-notification-teardown [web] Tear down papers-notification-banner GitOrigin-RevId: c6cb0affe85147f34f3dc6c36041fe190faf7ff2 --- .../Project/ProjectListController.mjs | 9 -- .../web/frontend/extracted-translations.json | 3 - .../hooks/use-papers-notification.ts | 16 ---- .../papers-notification-banner.tsx | 86 ------------------- .../notifications/user-notifications.tsx | 5 -- services/web/locales/en.json | 3 - 6 files changed, 122 deletions(-) delete mode 100644 services/web/frontend/js/features/project-list/components/notifications/hooks/use-papers-notification.ts delete mode 100644 services/web/frontend/js/features/project-list/components/notifications/papers-notification-banner.tsx diff --git a/services/web/app/src/Features/Project/ProjectListController.mjs b/services/web/app/src/Features/Project/ProjectListController.mjs index 2e1ca6a01a..60d964e532 100644 --- a/services/web/app/src/Features/Project/ProjectListController.mjs +++ b/services/web/app/src/Features/Project/ProjectListController.mjs @@ -403,15 +403,6 @@ async function projectListPage(req, res, next) { logger.error({ err: error }, 'Failed to get individual subscription') } - // Get the user's assignment for the papers notification banner split test, - // which populates splitTestVariants with a value for the split test name and - // allows Pug to send it to the browser - await SplitTestHandler.promises.getAssignment( - req, - res, - 'papers-notification-banner' - ) - const aiAssistNotificationAssignment = await SplitTestHandler.promises.getAssignment( req, diff --git a/services/web/frontend/extracted-translations.json b/services/web/frontend/extracted-translations.json index 0ab9ce236b..7a1655fcea 100644 --- a/services/web/frontend/extracted-translations.json +++ b/services/web/frontend/extracted-translations.json @@ -130,7 +130,6 @@ "all_projects_will_be_transferred_immediately": "", "all_these_experiments_are_available_exclusively": "", "allows_to_search_by_author_title_etc_possible_to_pull_results_directly_from_your_reference_manager_if_connected": "", - "already_have_a_papers_account": "", "an_email_has_already_been_sent_to": "", "an_error_occured_while_restoring_project": "", "an_error_occurred_when_verifying_the_coupon_code": "", @@ -1924,7 +1923,6 @@ "try_for_free": "", "try_it_for_free": "", "try_now": "", - "try_papers_for_free": "", "try_premium_for_free": "", "try_recompile_project_or_troubleshoot": "", "try_relinking_provider": "", @@ -2142,7 +2140,6 @@ "you_can_manage_your_reference_manager_integrations_from_your_account_settings_page": "", "you_can_now_enable_sso": "", "you_can_now_log_in_sso": "", - "you_can_now_sync_your_papers_library_directly_with_your_overleaf_projects": "", "you_can_request_a_maximum_of_limit_fixes_per_day": "", "you_can_select_or_invite_collaborator": "", "you_can_select_or_invite_collaborator_plural": "", diff --git a/services/web/frontend/js/features/project-list/components/notifications/hooks/use-papers-notification.ts b/services/web/frontend/js/features/project-list/components/notifications/hooks/use-papers-notification.ts deleted file mode 100644 index 42eafe25c0..0000000000 --- a/services/web/frontend/js/features/project-list/components/notifications/hooks/use-papers-notification.ts +++ /dev/null @@ -1,16 +0,0 @@ -import { useFeatureFlag } from '@/shared/context/split-test-context' -import getMeta from '@/utils/meta' - -export const usePapersNotification = () => { - const user = getMeta('ol-user') - const inRollout = useFeatureFlag('papers-notification-banner') - const shouldShow = - inRollout && - user && - (user.features?.references || user.features?.papers) && - !user.refProviders?.mendeley && - !user.refProviders?.zotero && - !user.refProviders?.papers - - return { shouldShow } -} diff --git a/services/web/frontend/js/features/project-list/components/notifications/papers-notification-banner.tsx b/services/web/frontend/js/features/project-list/components/notifications/papers-notification-banner.tsx deleted file mode 100644 index 5cb0c0e024..0000000000 --- a/services/web/frontend/js/features/project-list/components/notifications/papers-notification-banner.tsx +++ /dev/null @@ -1,86 +0,0 @@ -import { memo, useCallback, useEffect } from 'react' -import Notification from './notification' -import { Trans, useTranslation } from 'react-i18next' -import OLButton from '@/features/ui/components/ol/ol-button' -import usePersistedState from '@/shared/hooks/use-persisted-state' -import { sendMB } from '@/infrastructure/event-tracking' - -function PapersNotificationBanner() { - const { t } = useTranslation() - const [dismissed, setDismissed] = usePersistedState( - 'papers-notification-banner-dismissed', - false - ) - - useEffect(() => { - if (!dismissed) { - sendMB('promo-prompt', { - location: 'dashboard-banner', - name: 'papers-integration', - }) - } - }, [dismissed]) - - const handleClose = useCallback(() => { - sendMB('promo-dismiss', { - location: 'dashboard-banner', - name: 'papers-integration', - }) - setDismissed(true) - }, [setDismissed]) - - const handlePapersButtonClick = useCallback(() => { - sendMB('promo-click', { - location: 'dashboard-banner', - name: 'papers-integration', - type: 'click-try-for-free', - }) - }, []) - - const handleSettingsLinkClick = useCallback(() => { - sendMB('promo-click', { - location: 'dashboard-banner', - name: 'papers-integration', - type: 'click-link-account', - }) - }, []) - - if (dismissed) return null - - return ( - - , - ]} - /> -

- } - action={ - - {t('try_papers_for_free')} - - } - /> - ) -} - -export default memo(PapersNotificationBanner) diff --git a/services/web/frontend/js/features/project-list/components/notifications/user-notifications.tsx b/services/web/frontend/js/features/project-list/components/notifications/user-notifications.tsx index b21cfd28ea..89570b9240 100644 --- a/services/web/frontend/js/features/project-list/components/notifications/user-notifications.tsx +++ b/services/web/frontend/js/features/project-list/components/notifications/user-notifications.tsx @@ -13,9 +13,7 @@ import { DeprecatedBrowser, isDeprecatedBrowser, } from '@/shared/components/deprecated-browser' -import PapersNotificationBanner from './papers-notification-banner' import AiAssistBanner from './ai-assist-banner' -import { usePapersNotification } from './hooks/use-papers-notification' const [enrollmentNotificationModule] = importOverleafModules( 'managedGroupSubscriptionEnrollmentNotification' @@ -35,8 +33,6 @@ function UserNotifications() { const groupSubscriptionsPendingEnrollment = getMeta('ol-groupSubscriptionsPendingEnrollment') || [] - const { shouldShow: showPapersNotificationBanner } = usePapersNotification() - return (
    @@ -57,7 +53,6 @@ function UserNotifications() { {USGovBanner && } - {showPapersNotificationBanner && } diff --git a/services/web/locales/en.json b/services/web/locales/en.json index c77180d440..4aeb809ae9 100644 --- a/services/web/locales/en.json +++ b/services/web/locales/en.json @@ -159,7 +159,6 @@ "all_the_pros_of_our_standard_plan_plus_unlimited_collab": "All the pros of our standard plan, plus unlimited collaborators per project.", "all_these_experiments_are_available_exclusively": "All these experiments are available exclusively to members of the Labs program. If you sign up, you can choose which experiments you want to try.", "allows_to_search_by_author_title_etc_possible_to_pull_results_directly_from_your_reference_manager_if_connected": "Allows to search by author, title, etc. Possible to pull results directly from your reference manager (if connected).", - "already_have_a_papers_account": "Managing your citations and bibliographies in Overleaf just got way easier! Already have a Papers account? <0>Link your account here.", "already_have_an_account": "Already have an account?", "already_have_sl_account": "Already have an __appName__ account?", "also": "Also", @@ -2454,7 +2453,6 @@ "try_for_free": "Try for free", "try_it_for_free": "Try it for free", "try_now": "Try Now", - "try_papers_for_free": "Try Papers for free", "try_premium_for_free": "Try Premium for free", "try_recompile_project_or_troubleshoot": "Please try recompiling the project from scratch, and if that doesn’t help, follow our <0>troubleshooting guide.", "try_relinking_provider": "It looks like you need to re-link your __provider__ account.", @@ -2698,7 +2696,6 @@ "you_can_manage_your_reference_manager_integrations_from_your_account_settings_page": "You can manage your reference manager integrations from your <0>account settings page.", "you_can_now_enable_sso": "You can now enable SSO on your group settings page.", "you_can_now_log_in_sso": "You can now log in through your institution and if eligible you will receive <0>__appName__ Professional features.", - "you_can_now_sync_your_papers_library_directly_with_your_overleaf_projects": "You can now sync your Papers library directly with your Overleaf projects", "you_can_opt_in_and_out_of_the_program_at_any_time_on_this_page": "You can <0>opt in and out of the program at any time on this page", "you_can_request_a_maximum_of_limit_fixes_per_day": "You can request a maximum of __limit__ fixes per day. Please try again tomorrow.", "you_can_select_or_invite_collaborator": "You can select or invite __count__ collaborator on your current plan. Upgrade to add more editors or reviewers.",