From c1ad4d237bf8cfd25745b319edcea708964bd287 Mon Sep 17 00:00:00 2001 From: Mathias Jakobsen Date: Mon, 8 Jul 2024 11:15:20 +0100 Subject: [PATCH] Merge pull request #19247 from overleaf/mj-figure-snippet [web] Default to half line width in figure snippet GitOrigin-RevId: 477ab7fec21a040a5974d807dde3604882c38c82 --- .../languages/latex/completions/data/environments.ts | 2 +- .../components/codemirror-editor-visual.spec.tsx | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/services/web/frontend/js/features/source-editor/languages/latex/completions/data/environments.ts b/services/web/frontend/js/features/source-editor/languages/latex/completions/data/environments.ts index 2864789865..0d32962563 100644 --- a/services/web/frontend/js/features/source-editor/languages/latex/completions/data/environments.ts +++ b/services/web/frontend/js/features/source-editor/languages/latex/completions/data/environments.ts @@ -37,7 +37,7 @@ export const environments = new Map([ 'figure', `\\begin{figure} \t\\centering -\t\\includegraphics{$1} +\t\\includegraphics[width=0.5\\linewidth]{$1} \t\\caption{\${2:Caption}} \t\\label{\${3:fig:enter-label}} \\end{figure}`, diff --git a/services/web/test/frontend/features/source-editor/components/codemirror-editor-visual.spec.tsx b/services/web/test/frontend/features/source-editor/components/codemirror-editor-visual.spec.tsx index 161c58d1fc..dacd99b248 100644 --- a/services/web/test/frontend/features/source-editor/components/codemirror-editor-visual.spec.tsx +++ b/services/web/test/frontend/features/source-editor/components/codemirror-editor-visual.spec.tsx @@ -249,8 +249,8 @@ describe(' in Visual mode', function () { cy.get('@third-line').type('path/to/image') cy.get('@third-line').should( - 'have.text', - ' \\includegraphics{path/to/image}' + 'contain.text', + ' \\includegraphics[width=0.5\\linewidth]{path/to/image}' ) // move the cursor out of the figure @@ -258,8 +258,8 @@ describe(' in Visual mode', function () { // Should be removed from dom when line is hidden cy.get('.cm-content').should( - 'not.contain', - '\\includegraphics{path/to/image}' + 'not.contain.text', + '\\includegraphics[width=0.5\\linewidth]{path/to/image}' ) cy.get('img.ol-cm-graphics').should('have.attr', 'src', 'path/to/image')