From c3ad6645fe85df086ec040fe6fe1f3ea4b624ed6 Mon Sep 17 00:00:00 2001 From: Brian Gough Date: Wed, 26 Apr 2023 14:25:22 +0100 Subject: [PATCH] Merge pull request #12816 from overleaf/bg-recurly-scripts-cleanup sort recurly script JSON outputs for consistency GitOrigin-RevId: e5dc789fd834e9864912e3ef14ac3e6bf8eb7d99 --- services/web/scripts/recurly/generate_recurly_prices.js | 4 ++-- services/web/scripts/recurly/recurly_prices.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/services/web/scripts/recurly/generate_recurly_prices.js b/services/web/scripts/recurly/generate_recurly_prices.js index b8b52e3bed..4279bc921d 100644 --- a/services/web/scripts/recurly/generate_recurly_prices.js +++ b/services/web/scripts/recurly/generate_recurly_prices.js @@ -46,7 +46,7 @@ function computePrices(plan) { unitAmount: parseInt(prices[currency], 10), }) } - return result + return _.sortBy(result, 'currency') } // Handle prices for license add-ons associated with group plans @@ -106,7 +106,7 @@ function generate(inputFile, outputFile) { const input = fs.readFileSync(inputFile, 'utf8') const rawRecords = csv.parse(input, { columns: true }) // transform the raw records into the output format - const plans = rawRecords.map(transformRecordToPlan) + const plans = _.sortBy(rawRecords, 'plan_code').map(transformRecordToPlan) const output = JSON.stringify(plans, null, 2) fs.writeFileSync(outputFile, output) } diff --git a/services/web/scripts/recurly/recurly_prices.js b/services/web/scripts/recurly/recurly_prices.js index e483f33bd6..6a7151c613 100644 --- a/services/web/scripts/recurly/recurly_prices.js +++ b/services/web/scripts/recurly/recurly_prices.js @@ -35,7 +35,7 @@ async function getRecurlyPlans() { } result.push(plan) } - return result + return _.sortBy(result, 'code') } async function getRecurlyPlanAddOns(plan) {