agw/overleaf-cep
1
0
Fork 0
mirror of https://github.com/yu-i-i/overleaf-cep.git synced 2026-11-14 22:23:42 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #22304 from overleaf/mf-clean-up-latam-v2-test

Browse Source 
[web] Tear down LATAM geo-pricing v2 split test

GitOrigin-RevId: ca379c7ace5600aa31559c82e166c7ea67c6c26d
This commit is contained in:
M Fahru
2024-12-10 09:05:22 +00:00
committed by Copybot
parent 5a447aa349
commit c898e3f323
4 changed files with 165 additions and 310 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/web/app/src/Features/Project/ProjectListController.mjs
+1 -10
View File
@@ -396,13 +396,6 @@ async function projectListPage(req, res, next) {
usersBestSubscription?.type === 'free' ||
usersBestSubscription?.type === 'standalone-ai-add-on'
) {
const latamGeoPricingAssignment =
await SplitTestHandler.promises.getAssignment(
req,
res,
'geo-pricing-latam-v2'
)
const { countryCode, currencyCode } =
await GeoIpLookup.promises.getCurrencyCode(req.ip)
@@ -411,9 +404,7 @@ async function projectListPage(req, res, next) {
}
showBrlGeoBanner = countryCode === 'BR'
showLATAMBanner =
latamGeoPricingAssignment.variant === 'latam' &&
['MX', 'CO', 'CL', 'PE'].includes(countryCode)
showLATAMBanner = ['MX', 'CO', 'CL', 'PE'].includes(countryCode)
// LATAM Banner needs to know which currency to display
if (showLATAMBanner) {
recommendedCurrency = currencyCode
services/web/app/src/Features/Subscription/SubscriptionController.js
+14 -41
View File
@@ -68,10 +68,8 @@ function _getGroupPlanModalDefaults(req, currency) {
}
}
function _plansBanners({ geoPricingLATAMTestVariant, countryCode }) {
const showLATAMBanner =
geoPricingLATAMTestVariant === 'latam' &&
['MX', 'CO', 'CL', 'PE'].includes(countryCode)
function _plansBanners(countryCode) {
const showLATAMBanner = ['MX', 'CO', 'CL', 'PE'].includes(countryCode)
const showInrGeoBanner = countryCode === 'IN'
const showBrlGeoBanner = countryCode === 'BR'
return { showLATAMBanner, showInrGeoBanner, showBrlGeoBanner }
@@ -105,20 +103,15 @@ async function plansPage(req, res) {
const plans = SubscriptionViewModelBuilder.buildPlansList()
const { currency, countryCode, geoPricingLATAMTestVariant } =
await _getRecommendedCurrency(req, res)
const { currency, countryCode } = await _getRecommendedCurrency(req, res)
const latamCountryBannerDetails = await getLatamCountryBannerDetails(req, res)
const groupPlanModalDefaults = _getGroupPlanModalDefaults(req, currency)
const currentView = 'annual'
const { showLATAMBanner, showInrGeoBanner, showBrlGeoBanner } = _plansBanners(
{
geoPricingLATAMTestVariant,
countryCode,
}
)
const { showLATAMBanner, showInrGeoBanner, showBrlGeoBanner } =
_plansBanners(countryCode)
const localCcyAssignment = await SplitTestHandler.promises.getAssignment(
req,
@@ -163,8 +156,7 @@ async function plansPage(req, res) {
}
async function plansPageLightDesign(req, res) {
const { currency, countryCode, geoPricingLATAMTestVariant } =
await _getRecommendedCurrency(req, res)
const { currency, countryCode } = await _getRecommendedCurrency(req, res)
const language = req.i18n.language || 'en'
const currentView = 'annual'
@@ -181,12 +173,8 @@ async function plansPageLightDesign(req, res) {
? formatCurrencyLocalized
: SubscriptionHelper.formatCurrencyDefault
const { showLATAMBanner, showInrGeoBanner, showBrlGeoBanner } = _plansBanners(
{
geoPricingLATAMTestVariant,
countryCode,
}
)
const { showLATAMBanner, showInrGeoBanner, showBrlGeoBanner } =
_plansBanners(countryCode)
const latamCountryBannerDetails = await getLatamCountryBannerDetails(req, res)
@@ -358,8 +346,10 @@ async function interstitialPaymentPage(req, res) {
}
const user = SessionManager.getSessionUser(req.session)
const { recommendedCurrency, countryCode, geoPricingLATAMTestVariant } =
await _getRecommendedCurrency(req, res)
const { recommendedCurrency, countryCode } = await _getRecommendedCurrency(
req,
res
)
const latamCountryBannerDetails = await getLatamCountryBannerDetails(req, res)
@@ -371,10 +361,7 @@ async function interstitialPaymentPage(req, res) {
res.redirect('/user/subscription?hasSubscription=true')
} else {
const { showLATAMBanner, showInrGeoBanner, showBrlGeoBanner } =
_plansBanners({
geoPricingLATAMTestVariant,
countryCode,
})
_plansBanners(countryCode)
const localCcyAssignment = await SplitTestHandler.promises.getAssignment(
req,
@@ -827,20 +814,7 @@ async function _getRecommendedCurrency(req, res) {
}
const currencyLookup = await GeoIpLookup.promises.getCurrencyCode(ip)
const countryCode = currencyLookup.countryCode
let recommendedCurrency = currencyLookup.currencyCode
const assignmentLATAM = await SplitTestHandler.promises.getAssignment(
req,
res,
'geo-pricing-latam-v2'
)
if (
['MXN', 'COP', 'CLP', 'PEN'].includes(recommendedCurrency) &&
assignmentLATAM?.variant === 'default'
) {
recommendedCurrency = GeoIpLookup.DEFAULT_CURRENCY_CODE
}
const recommendedCurrency = currencyLookup.currencyCode
let currency = null
const queryCurrency = req.query.currency?.toUpperCase()
@@ -854,7 +828,6 @@ async function _getRecommendedCurrency(req, res) {
currency,
recommendedCurrency,
countryCode,
geoPricingLATAMTestVariant: assignmentLATAM?.variant,
}
}