From c8ad33155158f22f1e09a6e54dabc8e49c251cd9 Mon Sep 17 00:00:00 2001 From: Brian Gough Date: Mon, 13 Nov 2017 09:41:04 +0000 Subject: [PATCH] fix unit tests --- .../test/unit/coffee/DocumentUpdaterControllerTests.coffee | 6 +++--- .../test/unit/coffee/WebsocketControllerTests.coffee | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/services/real-time/test/unit/coffee/DocumentUpdaterControllerTests.coffee b/services/real-time/test/unit/coffee/DocumentUpdaterControllerTests.coffee index cb77a11513..fdd2f5fd5c 100644 --- a/services/real-time/test/unit/coffee/DocumentUpdaterControllerTests.coffee +++ b/services/real-time/test/unit/coffee/DocumentUpdaterControllerTests.coffee @@ -11,7 +11,7 @@ describe "DocumentUpdaterController", -> @callback = sinon.stub() @io = { "mock": "socket.io" } @EditorUpdatesController = SandboxedModule.require modulePath, requires: - "logger-sharelatex": @logger = { error: sinon.stub(), log: sinon.stub() } + "logger-sharelatex": @logger = { error: sinon.stub(), log: sinon.stub(), warn: sinon.stub() } "settings-sharelatex": @settings = redis: documentupdater: @@ -125,8 +125,8 @@ describe "DocumentUpdaterController", -> clients: sinon.stub().returns(@clients) @EditorUpdatesController._processErrorFromDocumentUpdater @io, @doc_id, "Something went wrong" - it "should log out an error", -> - @logger.error.called.should.equal true + it "should log a warning", -> + @logger.warn.called.should.equal true it "should disconnect all clients in that document", -> @io.sockets.clients.calledWith(@doc_id).should.equal true diff --git a/services/real-time/test/unit/coffee/WebsocketControllerTests.coffee b/services/real-time/test/unit/coffee/WebsocketControllerTests.coffee index dd220d254a..00f0638fb0 100644 --- a/services/real-time/test/unit/coffee/WebsocketControllerTests.coffee +++ b/services/real-time/test/unit/coffee/WebsocketControllerTests.coffee @@ -32,7 +32,7 @@ describe 'WebsocketController', -> "./DocumentUpdaterManager": @DocumentUpdaterManager = {} "./ConnectedUsersManager": @ConnectedUsersManager = {} "./WebsocketLoadBalancer": @WebsocketLoadBalancer = {} - "logger-sharelatex": @logger = { log: sinon.stub(), error: sinon.stub() } + "logger-sharelatex": @logger = { log: sinon.stub(), error: sinon.stub(), warn: sinon.stub() } "metrics-sharelatex": @metrics = inc: sinon.stub() set: sinon.stub() @@ -514,8 +514,8 @@ describe 'WebsocketController', -> # it "should disconnect the client", -> # @client.disconnect.called.should.equal true - it "should log an error", -> - @logger.error.called.should.equal true + it "should log a warning", -> + @logger.warn.called.should.equal true it "should call the callback with the error", -> @callback.calledWith(@error).should.equal true