From c919960d2b266b079f1765a04510fbf2a5b81ec7 Mon Sep 17 00:00:00 2001 From: David <33458145+davidmcpowell@users.noreply.github.com> Date: Thu, 16 Jan 2025 10:02:10 +0000 Subject: [PATCH] Merge pull request #22902 from overleaf/dp-remove-presentation-mode-flag Remove pdf-presentation-mode feature flag GitOrigin-RevId: 14e64115c539fe2721150ed6f09dfcc4ce9cbaaa --- services/web/app/src/Features/Project/ProjectController.js | 1 - .../js/features/pdf-preview/components/pdf-zoom-dropdown.tsx | 5 +---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/services/web/app/src/Features/Project/ProjectController.js b/services/web/app/src/Features/Project/ProjectController.js index 0e0bf3a800..c8f88c18d9 100644 --- a/services/web/app/src/Features/Project/ProjectController.js +++ b/services/web/app/src/Features/Project/ProjectController.js @@ -341,7 +341,6 @@ const _ProjectController = { 'pdf-caching-mode', 'pdf-caching-prefetch-large', 'pdf-caching-prefetching', - 'pdf-presentation-mode', 'revert-file', 'revert-project', 'review-panel-redesign', diff --git a/services/web/frontend/js/features/pdf-preview/components/pdf-zoom-dropdown.tsx b/services/web/frontend/js/features/pdf-preview/components/pdf-zoom-dropdown.tsx index 6dc05cfc8f..8b3f1f4a76 100644 --- a/services/web/frontend/js/features/pdf-preview/components/pdf-zoom-dropdown.tsx +++ b/services/web/frontend/js/features/pdf-preview/components/pdf-zoom-dropdown.tsx @@ -3,7 +3,6 @@ import { useEffect, useState } from 'react' import { useTranslation } from 'react-i18next' import ControlledDropdown from '@/shared/components/controlled-dropdown' import classNames from 'classnames' -import { useFeatureFlag } from '@/shared/context/split-test-context' import BootstrapVersionSwitcher from '@/features/ui/components/bootstrap-5/bootstrap-version-switcher' import { Dropdown, @@ -49,8 +48,6 @@ function PdfZoomDropdown({ }: PdfZoomDropdownProps) { const { t } = useTranslation() - const enablePresentationMode = useFeatureFlag('pdf-presentation-mode') - const [customZoomValue, setCustomZoomValue] = useState( rawScaleToPercentage(rawScale) ) @@ -59,7 +56,7 @@ function PdfZoomDropdown({ setCustomZoomValue(rawScaleToPercentage(rawScale)) }, [rawScale]) - const showPresentOption = enablePresentationMode && document.fullscreenEnabled + const showPresentOption = document.fullscreenEnabled return (