From ca5f438290f4ede976ff68f0fae28576c69a3d5e Mon Sep 17 00:00:00 2001 From: Tim Down Date: Fri, 10 Jun 2022 14:43:12 +0100 Subject: [PATCH] Merge pull request #8373 from overleaf/td-review-panel-scroll Scroll incrementally in response to mouse wheel in review panel GitOrigin-RevId: 2c1f119ae8dfd09b378a3b265c3543f88e2d1f65 --- .../js/ide/review-panel/directives/reviewPanelSorted.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/services/web/frontend/js/ide/review-panel/directives/reviewPanelSorted.js b/services/web/frontend/js/ide/review-panel/directives/reviewPanelSorted.js index 09ad75ed4c..c46d1a4436 100644 --- a/services/web/frontend/js/ide/review-panel/directives/reviewPanelSorted.js +++ b/services/web/frontend/js/ide/review-panel/directives/reviewPanelSorted.js @@ -255,7 +255,7 @@ export default App.directive('reviewPanelSorted', $timeout => ({ const old_top = parseInt(list.css('top')) const top = old_top - deltaY * 4 scrollAce(-top) - dispatchScrollEvent(-top) + dispatchScrollEvent(deltaY * 4) return e.preventDefault() }) @@ -287,11 +287,11 @@ export default App.directive('reviewPanelSorted', $timeout => ({ scrollPanel(scrollTop - paddingTop, height) }) - // send the scroll position to the CodeMirror 6 track changes extension - const dispatchScrollEvent = value => { + // Send scroll delta to the CodeMirror 6 track changes extension + const dispatchScrollEvent = scrollTopDelta => { window.dispatchEvent( new CustomEvent('review-panel:event', { - detail: { type: 'scroll', payload: value }, + detail: { type: 'scroll', payload: scrollTopDelta }, }) ) }