Merge pull request #27363 from overleaf/revert-26751-rd-landmarks

[web] Revert "Improve landmarks on the Project dashboard and Editor pages"

GitOrigin-RevId: 4bf0bbb9466db4436df4a72dcc70c320263dd168
This commit is contained in:
Antoine Clausse
2025-07-24 08:05:48 +00:00
committed by Copybot
parent a877979b11
commit ca71fec33b
41 changed files with 166 additions and 331 deletions
+4 -20
View File
@@ -85,11 +85,7 @@ describe('git-bridge', function () {
it('should render the git-bridge UI in the editor', function () {
maybeClearAllTokens()
createProject('git').as('projectId')
cy.findByRole('navigation', {
name: /Project actions/i,
})
.findByRole('button', { name: /Menu/i })
.click()
cy.get('header').findByText('Menu').click()
cy.findByText('Sync')
cy.findByText('Git').click()
cy.findByTestId('git-bridge-modal').within(() => {
@@ -104,11 +100,7 @@ describe('git-bridge', function () {
// Re-open
cy.url().then(url => cy.visit(url))
cy.findByRole('navigation', {
name: /Project actions/i,
})
.findByRole('button', { name: /Menu/i })
.click()
cy.get('header').findByText('Menu').click()
cy.findByText('Git').click()
cy.findByTestId('git-bridge-modal').within(() => {
cy.get('@projectId').then(id => {
@@ -196,11 +188,7 @@ describe('git-bridge', function () {
function checkGitAccess(access: 'readOnly' | 'readAndWrite') {
const recompile = throttledRecompile()
cy.findByRole('navigation', {
name: /Project actions/i,
})
.findByRole('button', { name: /Menu/i })
.click()
cy.get('header').findByText('Menu').click()
cy.findByText('Sync')
cy.findByText('Git').click()
cy.get('@projectId').then(projectId => {
@@ -382,11 +370,7 @@ Hello world
it('should not render the git-bridge UI in the editor', function () {
login('user@example.com')
createProject('maybe git')
cy.findByRole('navigation', {
name: /Project actions/i,
})
.findByRole('button', { name: /Menu/i })
.click()
cy.get('header').findByText('Menu').click()
cy.findByText('Word Count') // wait for lazy loading
cy.findByText('Sync').should('not.exist')
cy.findByText('Git').should('not.exist')
+3 -15
View File
@@ -37,11 +37,7 @@ describe('SandboxedCompiles', function () {
cy.findByText(/This is pdfTeX, Version .+ \(TeX Live 2023\) /)
cy.log('Switch TeXLive version from 2023 to 2022')
cy.findByRole('navigation', {
name: /Project actions/i,
})
.findByRole('button', { name: /Menu/i })
.click()
cy.get('header').findByText('Menu').click()
cy.findByText(LABEL_TEX_LIVE_VERSION)
.parent()
.findByText('2023')
@@ -217,11 +213,7 @@ describe('SandboxedCompiles', function () {
cy.findByText(/This is pdfTeX/)
cy.log('Switch compiler to from pdfLaTeX to XeLaTeX')
cy.findByRole('navigation', {
name: /Project actions/i,
})
.findByRole('button', { name: /Menu/i })
.click()
cy.get('header').findByText('Menu').click()
cy.findByText('Compiler')
.parent()
.findByText('pdfLaTeX')
@@ -253,11 +245,7 @@ describe('SandboxedCompiles', function () {
cy.findByText(/This is pdfTeX, Version .+ \(TeX Live 2025\) /)
cy.log('Check that there is no TeX Live version toggle')
cy.findByRole('navigation', {
name: /Project actions/i,
})
.findByRole('button', { name: /Menu/i })
.click()
cy.get('header').findByText('Menu').click()
cy.findByText('Word Count') // wait for lazy loading
cy.findByText(LABEL_TEX_LIVE_VERSION).should('not.exist')
})
+6 -30
View File
@@ -57,11 +57,7 @@ describe('Templates', () => {
cy.visit('/')
createProject(name).as('templateProjectId')
cy.findByRole('navigation', {
name: /Project actions/i,
})
.findByRole('button', { name: /Menu/i })
.click()
cy.get('header').findByText('Menu').click()
cy.findByText('Manage Template').click()
cy.findByText('Template Description')
@@ -140,11 +136,7 @@ describe('Templates', () => {
cy.get('@templateProjectId').then(projectId =>
cy.visit(`/project/${projectId}`)
)
cy.findByRole('navigation', {
name: /Project actions/i,
})
.findByRole('button', { name: /Menu/i })
.click()
cy.get('header').findByText('Menu').click()
cy.findByText('Manage Template').click()
cy.findByText('Publish').click()
cy.findByText('Unpublish', { timeout: 10_000 })
@@ -169,11 +161,7 @@ describe('Templates', () => {
cy.findByText('Open as Template').click()
cy.url().should('match', /\/project\/[a-f0-9]{24}$/)
cy.get('.project-name').findByText(name)
cy.findByRole('navigation', {
name: /Project actions/i,
})
.findByRole('button', { name: /Menu/i })
.click()
cy.get('header').findByText('Menu').click()
cy.findByText('Word Count') // wait for lazy loading
cy.findByText('Manage Template').should('not.exist')
@@ -192,11 +180,7 @@ describe('Templates', () => {
cy.get('@templateProjectId').then(projectId =>
cy.visit(`/project/${projectId}`)
)
cy.findByRole('navigation', {
name: /Project actions/i,
})
.findByRole('button', { name: /Menu/i })
.click()
cy.get('header').findByText('Menu').click()
cy.findByText('Manage Template').click()
cy.findByText('Unpublish')
@@ -207,11 +191,7 @@ describe('Templates', () => {
cy.get('@templateProjectId').then(projectId =>
cy.visit(`/project/${projectId}`)
)
cy.findByRole('navigation', {
name: /Project actions/i,
})
.findByRole('button', { name: /Menu/i })
.click()
cy.get('header').findByText('Menu').click()
cy.findByText('Manage Template').click()
cy.findByText('Unpublish').click()
cy.findByText('Publish')
@@ -237,11 +217,7 @@ describe('Templates', () => {
cy.visit('/')
createProject('maybe templates')
cy.findByRole('navigation', {
name: /Project actions/i,
})
.findByRole('button', { name: /Menu/i })
.click()
cy.get('header').findByText('Menu').click()
cy.findByText('Word Count') // wait for lazy loading
cy.findByText('Manage Template').should('not.exist')
+2 -8
View File
@@ -55,11 +55,7 @@ describe('Upgrading', function () {
cy.log('Trigger full flush')
recompile()
cy.findByRole('navigation', {
name: /Project Layout, Sharing, and Submission/i,
})
.findByRole('button', { name: /Menu/i })
.click()
cy.get('header').findByText('Menu').click()
cy.findByText('Source').click()
cy.get('.left-menu-modal-backdrop').click({ force: true })
}
@@ -120,9 +116,7 @@ describe('Upgrading', function () {
openProjectByName(PROJECT_NAME)
cy.url().should('match', /\/project\/[a-fA-F0-9]{24}/)
cy.findByRole('navigation', {
name: /Project actions/i,
}).within(() => {
cy.findByRole('navigation').within(() => {
cy.findByText(PROJECT_NAME)
})
const recompile = throttledRecompile()