From cae921b30a8dd417e442caf53d0984447a33a0c1 Mon Sep 17 00:00:00 2001
From: June Kelly <june@junek.xyz>
Date: Tue, 7 Sep 2021 09:29:14 +0100
Subject: [PATCH] Merge pull request #4892 from
 overleaf/jk-token-zip-download-fix

Fix download-zip-from-v1 for users without overleaf ids

GitOrigin-RevId: cf70a010041e143b573d534eb956e4b48b108436
---
 .../src/Features/History/HistoryController.js | 21 +++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/services/web/app/src/Features/History/HistoryController.js b/services/web/app/src/Features/History/HistoryController.js
index 00f97e33d8..1319f6b088 100644
--- a/services/web/app/src/Features/History/HistoryController.js
+++ b/services/web/app/src/Features/History/HistoryController.js
@@ -352,10 +352,31 @@ module.exports = HistoryController = {
         })
         return next(err)
       }
+      if (response.statusCode !== 200) {
+        if (response.statusCode === 404) {
+          return next(new Errors.NotFoundError('zip not found'))
+        } else {
+          return next(
+            new OError('Error while getting zip for download', {
+              v1ProjectId,
+              statusCode: response.statusCode,
+            })
+          )
+        }
+      }
       if (req.aborted) {
         // client has disconnected -- skip delayed s3 download
         return
       }
+      if (!body.zipUrl) {
+        return next(
+          new OError('Missing zipUrl, cannot fetch zip file', {
+            v1ProjectId,
+            body,
+            statusCode: response.statusCode,
+          })
+        )
+      }
       let retryAttempt = 0
       let retryDelay = 2000
       // retry for about 6 minutes starting with short delay