[web] fetch users subscriptions once from project dashboard (#25652)

* [web] fetch users subscriptions once from project dashboard

* [web] fix types

GitOrigin-RevId: 18de18f8d4237d97087ef92eaa5052f253a92813
This commit is contained in:
Jakob Ackermann
2025-05-16 09:00:58 +01:00
committed by Copybot
parent bc78432e62
commit cb7d75202b
3 changed files with 49 additions and 43 deletions

View File

@@ -53,11 +53,6 @@ describe('ProjectListController', function () {
this.settings = {
siteUrl: 'https://overleaf.com',
}
this.LimitationsManager = {
promises: {
userIsMemberOfGroupSubscription: sinon.stub().resolves(false),
},
}
this.TagsHandler = {
promises: {
getAllTags: sinon.stub().resolves(this.tags),
@@ -113,7 +108,11 @@ describe('ProjectListController', function () {
}
this.SubscriptionViewModelBuilder = {
promises: {
getBestSubscription: sinon.stub().resolves({ type: 'free' }),
getUsersSubscriptionDetails: sinon.stub().resolves({
bestSubscription: { type: 'free' },
individualSubscription: null,
memberGroupSubscriptions: [],
}),
},
}
this.SurveyHandler = {
@@ -126,11 +125,6 @@ describe('ProjectListController', function () {
ipMatcherAffiliation: sinon.stub().returns({ create: sinon.stub() }),
},
}
this.SubscriptionLocator = {
promises: {
getUserSubscription: sinon.stub().resolves({}),
},
}
this.GeoIpLookup = {
promises: {
getCurrencyCode: sinon.stub().resolves({
@@ -161,8 +155,6 @@ describe('ProjectListController', function () {
this.SplitTestSessionHandler,
'../../../../app/src/Features/User/UserController': this.UserController,
'../../../../app/src/Features/Project/ProjectHelper': this.ProjectHelper,
'../../../../app/src/Features/Subscription/LimitationsManager':
this.LimitationsManager,
'../../../../app/src/Features/Tags/TagsHandler': this.TagsHandler,
'../../../../app/src/Features/Notifications/NotificationsHandler':
this.NotificationsHandler,
@@ -180,8 +172,6 @@ describe('ProjectListController', function () {
this.UserPrimaryEmailCheckHandler,
'../../../../app/src/Features/Notifications/NotificationsBuilder':
this.NotificationBuilder,
'../../../../app/src/Features/Subscription/SubscriptionLocator':
this.SubscriptionLocator,
'../../../../app/src/infrastructure/GeoIpLookup': this.GeoIpLookup,
'../../../../app/src/Features/Tutorial/TutorialHandler':
this.TutorialHandler,
@@ -345,9 +335,13 @@ describe('ProjectListController', function () {
it('should show INR Banner for Indian users with free account', function (done) {
// usersBestSubscription is only available when saas feature is present
this.Features.hasFeature.withArgs('saas').returns(true)
this.SubscriptionViewModelBuilder.promises.getBestSubscription.resolves({
type: 'free',
})
this.SubscriptionViewModelBuilder.promises.getUsersSubscriptionDetails.resolves(
{
bestSubscription: {
type: 'free',
},
}
)
this.GeoIpLookup.promises.getCurrencyCode.resolves({
countryCode: 'IN',
})
@@ -361,9 +355,13 @@ describe('ProjectListController', function () {
it('should not show INR Banner for Indian users with premium account', function (done) {
// usersBestSubscription is only available when saas feature is present
this.Features.hasFeature.withArgs('saas').returns(true)
this.SubscriptionViewModelBuilder.promises.getBestSubscription.resolves({
type: 'individual',
})
this.SubscriptionViewModelBuilder.promises.getUsersSubscriptionDetails.resolves(
{
bestSubscription: {
type: 'individual',
},
}
)
this.GeoIpLookup.promises.getCurrencyCode.resolves({
countryCode: 'IN',
})
@@ -616,8 +614,8 @@ describe('ProjectListController', function () {
describe('enterprise banner', function () {
beforeEach(function (done) {
this.Features.hasFeature.withArgs('saas').returns(true)
this.LimitationsManager.promises.userIsMemberOfGroupSubscription.resolves(
{ isMember: false }
this.SubscriptionViewModelBuilder.promises.getUsersSubscriptionDetails.resolves(
{ memberGroupSubscriptions: [] }
)
this.UserGetter.promises.getUserFullEmails.resolves([
{
@@ -660,8 +658,8 @@ describe('ProjectListController', function () {
})
it('does not show banner if user is part of any group subscription', function () {
this.LimitationsManager.promises.userIsMemberOfGroupSubscription.resolves(
{ isMember: true }
this.SubscriptionViewModelBuilder.promises.getUsersSubscriptionDetails.resolves(
{ memberGroupSubscriptions: [{}] }
)
this.res.render = (pageName, opts) => {