From cd644320f43fe0a378d920a6d190c84874889200 Mon Sep 17 00:00:00 2001 From: Tim Down <158919+timdown@users.noreply.github.com> Date: Tue, 4 Mar 2025 09:22:04 +0000 Subject: [PATCH] Merge pull request #23998 from overleaf/td-resolved-thread-count Fix for resolved thread count display GitOrigin-RevId: c4f6848ed2e952981d20f157466db6dded99c3c9 --- .../components/review-panel-resolved-threads-menu.tsx | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/services/web/frontend/js/features/review-panel-new/components/review-panel-resolved-threads-menu.tsx b/services/web/frontend/js/features/review-panel-new/components/review-panel-resolved-threads-menu.tsx index 30a09ec2cd..8a722a1ec0 100644 --- a/services/web/frontend/js/features/review-panel-new/components/review-panel-resolved-threads-menu.tsx +++ b/services/web/frontend/js/features/review-panel-new/components/review-panel-resolved-threads-menu.tsx @@ -50,18 +50,18 @@ export const ReviewPanelResolvedThreadsMenu: FC = () => { return [] } - const resolvedThreads = [] + const allResolvedThreads = [] for (const [id, thread] of Object.entries(threads)) { if (thread.resolved) { - resolvedThreads.push({ thread, id }) + allResolvedThreads.push({ thread, id }) } } - resolvedThreads.sort((a, b) => { + allResolvedThreads.sort((a, b) => { return Date.parse(b.thread.resolved_at) - Date.parse(a.thread.resolved_at) }) - return resolvedThreads - }, [threads]) + return allResolvedThreads.filter(thread => allComments.has(thread.id)) + }, [threads, allComments]) if (loading) { return