From d0b6e877dc478895cd6ff9368b7147b4a34caa8f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timoth=C3=A9e=20Alby?= Date: Tue, 15 Sep 2020 14:48:27 +0200 Subject: [PATCH] Merge pull request #3159 from overleaf/ta-outline-item-scroll-fix Fix Outline Item Scroll for Highlighted Parents GitOrigin-RevId: e67ca4a3043cd60536dbd389438b5a67d6f38efa --- .../js/features/outline/components/outline-item.js | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/services/web/frontend/js/features/outline/components/outline-item.js b/services/web/frontend/js/features/outline/components/outline-item.js index 4749121a8c..273c06080f 100644 --- a/services/web/frontend/js/features/outline/components/outline-item.js +++ b/services/web/frontend/js/features/outline/components/outline-item.js @@ -55,18 +55,16 @@ function OutlineItem({ outlineItem, jumpToLine, highlightedLine }) { useEffect( () => { const wasHighlighted = isHighlightedRef.current - const isNowHighlighted = highlightedLine === outlineItem.line + isHighlightedRef.current = isHighlighted - isHighlightedRef.current = isNowHighlighted - - if (!wasHighlighted && isNowHighlighted) { + if (!wasHighlighted && isHighlighted) { scrollIntoViewIfNeeded(titleElementRef.current, { scrollMode: 'if-needed', block: 'center' }) } }, - [highlightedLine, titleElementRef, isHighlightedRef] + [isHighlighted, titleElementRef, isHighlightedRef] ) // don't set the aria-expanded attribute when there are no children