From d1410f46361d462fa5a99fd627b167308e96660a Mon Sep 17 00:00:00 2001 From: Jakob Ackermann Date: Wed, 12 Feb 2025 10:33:51 +0000 Subject: [PATCH] [web] avoid setting up users more than once in tests (#23558) * [web] avoid setting up users more than once in tests * [web] tests: simplify user exists check in User.setExtraAttributes GitOrigin-RevId: 4c526df7c933a38ab93d7760efbd0a9490d5582a --- services/web/test/acceptance/src/helpers/User.mjs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/services/web/test/acceptance/src/helpers/User.mjs b/services/web/test/acceptance/src/helpers/User.mjs index f91f428d6d..b2200756c4 100644 --- a/services/web/test/acceptance/src/helpers/User.mjs +++ b/services/web/test/acceptance/src/helpers/User.mjs @@ -240,7 +240,7 @@ class User { } setExtraAttributes(user) { - if ((user != null ? user._id : undefined) == null) { + if (!user?._id) { throw new Error('User does not exist') } this.id = user._id.toString() @@ -412,6 +412,7 @@ class User { } ensureUserExists(callback) { + if (this._id) return callback() // already exists const filter = { email: this.email } const options = { upsert: true, new: true, setDefaultsOnInsert: true }