Merge pull request #31909 from overleaf/ds-removing-useIsNewEditorEnabled-2

[Part 2] Removing the usage of `useIsNewEditorEnabled` for editor tear down

GitOrigin-RevId: 864652da0edcedab4f3b1ba47d8d42fb65260118

services/web/frontend/js/shared/hooks/use-editor-analytics.ts

@@ -1,4 +1,3 @@
-import { useIsNewEditorEnabled } from '@/features/ide-redesign/utils/new-editor-utils'
 import {
   Segmentation,
   sendMB,
@@ -10,22 +9,17 @@ import { useCallback } from 'react'
 export function populateEditorRedesignSegmentation<
   SegmentationType extends Segmentation,
 >(
-  segmentation: SegmentationType | undefined = {} as SegmentationType,
-  editorRedesign: boolean
+  segmentation: SegmentationType | undefined = {} as SegmentationType
 ): SegmentationType & { 'editor-redesign'?: 'enabled' } {
-  return editorRedesign
-    ? { ...segmentation, 'editor-redesign': 'enabled' }
-    : segmentation
+  return { ...segmentation, 'editor-redesign': 'enabled' }
 }
 
 export const useEditorAnalytics = () => {
-  const editorRedesign = useIsNewEditorEnabled()
-
   const populateSegmentation = useCallback(
     (segmentation: Segmentation | undefined = {}): Segmentation => {
-      return populateEditorRedesignSegmentation(segmentation, editorRedesign)
+      return populateEditorRedesignSegmentation(segmentation)
     },
-    [editorRedesign]
+    []
   )
 
   const sendEvent: typeof sendMB = useCallback(