From d9c9d74994d6a660d49c2b644dbdf0067558f65a Mon Sep 17 00:00:00 2001 From: Simon Detheridge Date: Thu, 13 Feb 2020 15:47:42 +0000 Subject: [PATCH] Remove unnecessary test for S3 file deletion S3 does not throw a not-found error when deleting a file that does not exist --- .../test/unit/js/S3PersistorTests.js | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/services/filestore/test/unit/js/S3PersistorTests.js b/services/filestore/test/unit/js/S3PersistorTests.js index ac104e36f2..aa9444428e 100644 --- a/services/filestore/test/unit/js/S3PersistorTests.js +++ b/services/filestore/test/unit/js/S3PersistorTests.js @@ -675,25 +675,6 @@ describe('S3PersistorTests', function() { }) }) }) - - describe('when the file does not exist', function() { - let error - - beforeEach(async function() { - S3Client.deleteObject = sinon.stub().returns({ - promise: sinon.stub().rejects(S3NotFoundError) - }) - try { - await S3Persistor.promises.deleteFile(bucket, key) - } catch (err) { - error = err - } - }) - - it('should throw a NotFoundError', function() { - expect(error).to.be.an.instanceOf(Errors.NotFoundError) - }) - }) }) describe('deleteDirectory', function() {