agw/overleaf-cep
1
0
Fork 0
mirror of https://github.com/yu-i-i/overleaf-cep.git synced 2026-11-15 06:33:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2859 from overleaf/ns-cmg-history-labels-deletion

Browse Source 
Ensure history label dissapears from UI when deleted

GitOrigin-RevId: fe48cbce9fbd70f7008043dc202a5d985bd6c5fb
This commit is contained in:
Jessica Lawshe
2020-06-12 02:10:35 +00:00
committed by Copybot
parent cc018357e1
commit d9e4bda90b
3 changed files with 124 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/web/test/frontend/ide/history/HistoryV2ManagerTests.js
+93 -2
View File
@@ -140,7 +140,7 @@ export default describe('HistoryV2Manager', function() {
}
]
inject(($q, $http, $rootScope) => {
inject(($q, $http, $filter, $rootScope) => {
this.$scope = $rootScope.$new()
this.$scope.project = {
features: {
@@ -152,7 +152,8 @@ export default describe('HistoryV2Manager', function() {
}
this.ide = {
$q: $q,
$http: $http
$http: $http,
$filter: $filter
}
this.localStorage = sinon.stub().returns(null)
this.historyManager = new HistoryV2Manager(
@@ -543,5 +544,95 @@ export default describe('HistoryV2Manager', function() {
})
})
})
describe('_loadLabels', function() {
it('should return labels list as is if there is a label for the last version', function() {
const labels = [
{
id: '1',
version: 1,
comment: 'foo',
created_at: new Date().toISOString()
},
{
id: '2',
version: 2,
comment: 'bar',
created_at: new Date().toISOString()
},
{
id: '3',
version: 3,
comment: 'baz',
created_at: new Date().toISOString()
}
]
const lastUpdate = 3
const labelsResult = this.historyManager._loadLabels(labels, lastUpdate)
expect(labelsResult).to.have.members(labels)
})
it('should return a labels list with a pseudo current state label if there is no label for the last version', function() {
const labels = [
{
id: '1',
version: 1,
comment: 'foo',
created_at: new Date().toISOString()
},
{
id: '2',
version: 2,
comment: 'bar',
created_at: new Date().toISOString()
},
{
id: '3',
version: 3,
comment: 'baz',
created_at: new Date().toISOString()
}
]
const lastUpdate = 5
const labelsResult = this.historyManager._loadLabels(labels, lastUpdate)
expect(labelsResult).to.include.members(labels)
expect(labelsResult[0].isPseudoCurrentStateLabel).to.equal(true)
expect(labelsResult[0].version).to.equal(5)
})
it('should keep pseudo label when deleting label', function() {
this.historyManager.$scope.history.labels = [
{
id: '1',
version: 1,
comment: 'foo',
created_at: new Date().toISOString()
}
]
const lastUpdate = 5
this.historyManager.$scope.history.labels = this.historyManager._loadLabels(
this.historyManager.$scope.history.labels,
lastUpdate
)
expect(
this.historyManager.$scope.history.labels[0].isPseudoCurrentStateLabel
).to.equal(true)
this.historyManager.$scope.history.labels = this.historyManager._loadLabels(
[],
lastUpdate
)
expect(
this.historyManager.$scope.history.labels[0].isPseudoCurrentStateLabel
).to.equal(true)
expect(this.historyManager.$scope.history.labels[0].version).to.equal(5)
})
})
})
})