From dba294377cb100fe76ed9a7d13be70544695abce Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timoth=C3=A9e=20Alby?= <timothee.alby@gmail.com>
Date: Tue, 14 Apr 2020 14:09:11 +0200
Subject: [PATCH] Merge pull request #2736 from overleaf/cmg-ns-set-root-doc

Ensure setRootDoc settings persist

GitOrigin-RevId: 76b7633719b4193dbd70ada98f2889730803b583
---
 .../js/ide/settings/controllers/SettingsController.js        | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/services/web/frontend/js/ide/settings/controllers/SettingsController.js b/services/web/frontend/js/ide/settings/controllers/SettingsController.js
index 76c8f8cb56..130701be80 100644
--- a/services/web/frontend/js/ide/settings/controllers/SettingsController.js
+++ b/services/web/frontend/js/ide/settings/controllers/SettingsController.js
@@ -198,7 +198,10 @@ define(['../../../base'], App =>
       }
       // don't save on initialisation, Angular passes oldRootDoc_id as
       // undefined in this case.
-      if (typeof oldRootDoc_id === 'undefined') {
+      if (
+        typeof rootDoc_id === 'undefined' &&
+        typeof oldRootDoc_id === 'undefined'
+      ) {
         return
       }
       // otherwise only save changes, null values are allowed