From dd018be4999d972898ef9fa38653d98c6fcedcc4 Mon Sep 17 00:00:00 2001
From: Alexandre Bourdin <abourdin@users.noreply.github.com>
Date: Fri, 10 Sep 2021 15:20:49 +0200
Subject: [PATCH] Merge pull request #5064 from
 overleaf/ab-analytics-smoke-check

Add null check for smoke test user in analytics manager

GitOrigin-RevId: 2ece12f1a674943577ecee272435df535225ec9e
---
 services/web/app/src/Features/Analytics/AnalyticsManager.js | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/services/web/app/src/Features/Analytics/AnalyticsManager.js b/services/web/app/src/Features/Analytics/AnalyticsManager.js
index 2437d001ed..cdf4698105 100644
--- a/services/web/app/src/Features/Analytics/AnalyticsManager.js
+++ b/services/web/app/src/Features/Analytics/AnalyticsManager.js
@@ -178,7 +178,11 @@ function _setUserProperty({ analyticsId, propertyName, propertyValue }) {
 
 function _isSmokeTestUser(userId) {
   const smokeTestUserId = Settings.smokeTest && Settings.smokeTest.userId
-  return smokeTestUserId != null && userId.toString() === smokeTestUserId
+  return (
+    smokeTestUserId != null &&
+    userId != null &&
+    userId.toString() === smokeTestUserId
+  )
 }
 
 function _isAnalyticsDisabled() {