From e1a653eb10df78e75ad64ce06f7ebe68a216a2de Mon Sep 17 00:00:00 2001 From: Mathias Jakobsen Date: Wed, 17 May 2023 09:26:03 +0100 Subject: [PATCH] Merge pull request #13118 from overleaf/mj-fix-centering-editable-graphics [web] Always update centering in editablegraphics updateDOM GitOrigin-RevId: 366a109c2006dea3cd3660f7a380fbbc0e203cca --- .../visual/visual-widgets/editable-graphics.ts | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/services/web/frontend/js/features/source-editor/extensions/visual/visual-widgets/editable-graphics.ts b/services/web/frontend/js/features/source-editor/extensions/visual/visual-widgets/editable-graphics.ts index 9ce588a068..6b04bc6c6d 100644 --- a/services/web/frontend/js/features/source-editor/extensions/visual/visual-widgets/editable-graphics.ts +++ b/services/web/frontend/js/features/source-editor/extensions/visual/visual-widgets/editable-graphics.ts @@ -19,19 +19,21 @@ export class EditableGraphicsWidget extends GraphicsWidget { } updateDOM(element: HTMLImageElement, view: EditorView): boolean { + this.destroyed = false + element.classList.toggle('ol-cm-environment-centered', this.centered) if ( this.filePath === element.dataset.filepath && element.dataset.width === String(this.figureData?.width?.toString()) ) { // Figure remained the same, so just update the event listener on the button - this.setEditDispatcher( - element.querySelector('.ol-cm-graphics-edit-button')!, - view + const button = element.querySelector( + '.ol-cm-graphics-edit-button' ) + if (button) { + this.setEditDispatcher(button, view) + } return true } - this.destroyed = false - element.classList.toggle('ol-cm-environment-centered', this.centered) this.renderGraphic(element, view) return true }