From 40f61bfa66b0744942543f63f415209d70108728 Mon Sep 17 00:00:00 2001 From: James Allen Date: Thu, 23 Feb 2017 15:10:03 +0100 Subject: [PATCH 1/3] Don't overlap border of overview panel with PDF bar --- .../web/public/stylesheets/app/editor/review-panel.less | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/services/web/public/stylesheets/app/editor/review-panel.less b/services/web/public/stylesheets/app/editor/review-panel.less index 71cff511d4..b46fd70992 100644 --- a/services/web/public/stylesheets/app/editor/review-panel.less +++ b/services/web/public/stylesheets/app/editor/review-panel.less @@ -149,12 +149,7 @@ } .rp-entry-list { - .rp-size-expanded & { - width: @review-panel-width; - } - .rp-size-mini & { - width: @review-off-width; - } + width: 100%; .rp-state-current-file & { position: absolute; From 3bdbe7e538b395927bc73768187d0977d6bd204f Mon Sep 17 00:00:00 2001 From: Paulo Reis Date: Fri, 24 Feb 2017 14:36:08 +0000 Subject: [PATCH 2/3] Set synctex controls z-index to the minimum working value. --- services/web/public/coffee/ide/directives/layout.coffee | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/web/public/coffee/ide/directives/layout.coffee b/services/web/public/coffee/ide/directives/layout.coffee index f20a37b342..7506c410f2 100644 --- a/services/web/public/coffee/ide/directives/layout.coffee +++ b/services/web/public/coffee/ide/directives/layout.coffee @@ -55,7 +55,7 @@ define [ controls.css({ position: "absolute" right: state.east.size - "z-index": 10 + "z-index": 3 }) resetOpenStates = () -> From 1646496f1912bf01b44097883a7c8c68017252f7 Mon Sep 17 00:00:00 2001 From: Paulo Reis Date: Fri, 24 Feb 2017 14:38:46 +0000 Subject: [PATCH 3/3] Patch overflow behaviour so that z-index is always higher by 1. --- services/web/public/coffee/ide/directives/layout.coffee | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/services/web/public/coffee/ide/directives/layout.coffee b/services/web/public/coffee/ide/directives/layout.coffee index 7506c410f2..21d9230b52 100644 --- a/services/web/public/coffee/ide/directives/layout.coffee +++ b/services/web/public/coffee/ide/directives/layout.coffee @@ -106,7 +106,14 @@ define [ , 0 if attrs.allowOverflowOn? - element.layout().allowOverflow(scope.$eval(attrs.allowOverflowOn)) + layoutObj = element.layout() + overflowPane = scope.$eval(attrs.allowOverflowOn) + overflowPaneEl = layoutObj.panes[overflowPane] + # Set the panel as overflowing (gives it higher z-index and sets overflow rules) + layoutObj.allowOverflow overflowPane + # Read the given z-index value and increment it, so that it's higher than synctex controls. + overflowPaneZVal = overflowPaneEl.css "z-index" + overflowPaneEl.css "z-index", overflowPaneZVal + 1 resetOpenStates() onInternalResize()