From e46901a21b190cf297ddfa6e8fb8357dbd000107 Mon Sep 17 00:00:00 2001 From: Shane Kilkelly Date: Tue, 26 Jul 2016 14:23:00 +0100 Subject: [PATCH] Send an empty keys array when there is no data --- .../coffee/Features/References/ReferencesController.coffee | 4 ++-- .../coffee/References/ReferencesControllerTests.coffee | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/services/web/app/coffee/Features/References/ReferencesController.coffee b/services/web/app/coffee/Features/References/ReferencesController.coffee index 5976af9430..305c4715b5 100644 --- a/services/web/app/coffee/Features/References/ReferencesController.coffee +++ b/services/web/app/coffee/Features/References/ReferencesController.coffee @@ -32,8 +32,8 @@ module.exports = ReferencesController = _handleIndexResponse: (req, res, projectId, shouldBroadcast, data) -> if !data? or !data.keys? - return res.send() - else if shouldBroadcast + return res.json({projectId, keys: []}) + if shouldBroadcast logger.log {projectId}, "emitting new references keys to connected clients" EditorRealTimeController.emitToRoom projectId, 'references:keys:updated', data.keys return res.json data diff --git a/services/web/test/UnitTests/coffee/References/ReferencesControllerTests.coffee b/services/web/test/UnitTests/coffee/References/ReferencesControllerTests.coffee index 0d58da7631..37a448d34a 100644 --- a/services/web/test/UnitTests/coffee/References/ReferencesControllerTests.coffee +++ b/services/web/test/UnitTests/coffee/References/ReferencesControllerTests.coffee @@ -134,9 +134,10 @@ describe "ReferencesController", -> @res.sendStatus.calledWith(400).should.equal false done() - it 'should close the response', (done) -> + it 'should send a response with an empty keys list', (done) -> @call () => - @res.send.called.should.equal true + @res.json.called.should.equal true + @res.json.calledWith({projectId: @projectId, keys: []}).should.equal true done() describe 'index', ->