From e4e054e8bbd3f3b8eb2a378d2fbb76b5468d1174 Mon Sep 17 00:00:00 2001 From: Alexandre Bourdin Date: Thu, 18 Apr 2024 17:06:35 +0200 Subject: [PATCH] Merge pull request #18008 from overleaf/ab-fix-anon-assignment-append [web] Fix anonymous assignment append to session GitOrigin-RevId: 402cd94ec6250e15f0e35cb69af3977c78ec5a7d --- .../Features/SplitTests/SplitTestSessionHandler.js | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/services/web/app/src/Features/SplitTests/SplitTestSessionHandler.js b/services/web/app/src/Features/SplitTests/SplitTestSessionHandler.js index 82995c745e..e2aae8b35b 100644 --- a/services/web/app/src/Features/SplitTests/SplitTestSessionHandler.js +++ b/services/web/app/src/Features/SplitTests/SplitTestSessionHandler.js @@ -84,8 +84,8 @@ async function appendAssignment(session, assignment) { const assignments = await getAssignments(session) if ( - _.find(assignments[assignment.splitTestName], { - splitTestName: assignment.splitTestName, + !_.find(assignments[assignment.splitTestName], { + variantName: assignment.variantName, versionNumber: assignment.versionNumber, }) ) { @@ -97,7 +97,12 @@ async function appendAssignment(session, assignment) { // const assignmentString = _buildAssignmentString(splitTest, assignment) // const separator = session.sta.length > 0 ? ';' : '' // session.sta += `${separator}${assignmentString}` - session.splitTests[assignment.splitTestName].push(assignment) + session.splitTests[assignment.splitTestName].push({ + variantName: assignment.variantName, + versionNumber: assignment.versionNumber, + phase: assignment.phase, + assignedAt: assignment.assignedAt, + }) } }