From f0d7658bdd6a4654d3f8d638f4813ed775bde7a2 Mon Sep 17 00:00:00 2001 From: James Allen Date: Wed, 3 Jan 2018 16:43:15 +0000 Subject: [PATCH 1/2] Don't show import dialog for projects, just link to v1 editor --- services/web/app/views/project/list/v1-item.pug | 11 ++++++++--- services/web/public/stylesheets/app/project-list.less | 4 ---- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/services/web/app/views/project/list/v1-item.pug b/services/web/app/views/project/list/v1-item.pug index 61815068f6..2e1b24be3e 100644 --- a/services/web/app/views/project/list/v1-item.pug +++ b/services/web/app/views/project/list/v1-item.pug @@ -5,10 +5,15 @@ tooltip-append-to-body="true" ) span - button.btn.btn-link.v1ProjectName( - ng-click="openV1ImportModal(project)" - stop-propagation="click" + a.projectName( + href=settings.overleaf.host + "/{{project.id}}" + target="_blank" ) {{project.name}} + //- To re-enable the import dialog: + //- a.projectName( + //- ng-click="openV1ImportModal(project)" + //- stop-propagation="click" + //- ) {{project.name}} .col-xs-2 span.owner {{ownerName()}} diff --git a/services/web/public/stylesheets/app/project-list.less b/services/web/public/stylesheets/app/project-list.less index 94469b246c..3a5ea560db 100644 --- a/services/web/public/stylesheets/app/project-list.less +++ b/services/web/public/stylesheets/app/project-list.less @@ -337,10 +337,6 @@ ul.project-list { .projectName { margin-right: @line-height-computed / 4; } - .v1ProjectName { - margin-right: @line-height-computed / 4; - padding: 0; - } .tag-label { margin-left: @line-height-computed / 4; From 967353d0800beff128fd1110c78da239a0593bb0 Mon Sep 17 00:00:00 2001 From: James Allen Date: Wed, 3 Jan 2018 17:05:47 +0000 Subject: [PATCH 2/2] Update comment to use button for import dialog for a11y --- services/web/app/views/project/list/v1-item.pug | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/services/web/app/views/project/list/v1-item.pug b/services/web/app/views/project/list/v1-item.pug index 2e1b24be3e..b53349e158 100644 --- a/services/web/app/views/project/list/v1-item.pug +++ b/services/web/app/views/project/list/v1-item.pug @@ -9,8 +9,8 @@ href=settings.overleaf.host + "/{{project.id}}" target="_blank" ) {{project.name}} - //- To re-enable the import dialog: - //- a.projectName( + //- To re-enable the import dialog (may need style changing for padding/line-height): + //- button.btn.btn-link.projectName( //- ng-click="openV1ImportModal(project)" //- stop-propagation="click" //- ) {{project.name}}