agw/overleaf-cep
1
0
Fork 0
mirror of https://github.com/yu-i-i/overleaf-cep.git synced 2026-06-01 21:31:36 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #22321 from overleaf/msm-force-flag-delete-user

Browse Source 
[web] Fix user deletion in CE/SP when email does not exist

GitOrigin-RevId: 051f822318d63c8a9f50d5e9aeca095f3b37efb4
This commit is contained in:
Miguel Serrano
2025-01-10 09:57:32 +01:00
committed by Copybot
parent ac8c381597
commit e6ceb314cb
3 changed files with 53 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

49
services/web/test/unit/src/User/UserDeleterTests.js
View File

@@ -299,18 +299,45 @@ describe('UserDeleter', function () {
this.DeletedUserMock.verify()
})
it('should email the user', async function () {
await this.UserDeleter.promises.deleteUser(this.userId, {
ipAddress: this.ipAddress,
describe('email notifications', function () {
it('should email the user', async function () {
await this.UserDeleter.promises.deleteUser(this.userId, {
ipAddress: this.ipAddress,
})
const emailOptions = {
to: 'bob@bob.com',
action: 'account deleted',
actionDescribed: 'your Overleaf account was deleted',
}
expect(
this.EmailHandler.promises.sendEmail
).to.have.been.calledWith('securityAlert', emailOptions)
})
it('should fail when the email service fails', async function () {
this.EmailHandler.promises.sendEmail = sinon
.stub()
.rejects(new Error('email failed'))
await expect(
this.UserDeleter.promises.deleteUser(this.userId, {
ipAddress: this.ipAddress,
})
).to.be.rejectedWith('email failed')
})
describe('with "force: true" option', function () {
it('should succeed when the email service fails', async function () {
this.EmailHandler.promises.sendEmail = sinon
.stub()
.rejects(new Error('email failed'))
await expect(
this.UserDeleter.promises.deleteUser(this.userId, {
ipAddress: this.ipAddress,
force: true,
})
).to.be.fulfilled
})
})
const emailOptions = {
to: 'bob@bob.com',
action: 'account deleted',
actionDescribed: 'your Overleaf account was deleted',
}
expect(
this.EmailHandler.promises.sendEmail
).to.have.been.calledWith('securityAlert', emailOptions)
})
it('should add an audit log entry', async function () {