agw/overleaf-cep
1
0
Fork 0
mirror of https://github.com/yu-i-i/overleaf-cep.git synced 2026-06-08 08:39:03 +02:00
Code Issues Packages Projects Releases Wiki Activity

Remove PDF detach split test (#9275)

Browse Source 
GitOrigin-RevId: 9e227fe45d874e01c4282ebbe489d7bd6d2250ac
This commit is contained in:
Alf Eaton
2022-08-18 09:14:44 +01:00
committed by Copybot
parent ac64394b49
commit e741eb0cb8
9 changed files with 21 additions and 187 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/web/test/unit/src/Project/ProjectControllerTests.js
-61
View File
@@ -1364,67 +1364,6 @@ describe('ProjectController', function () {
})
})
describe('feature flags', function () {
describe('showPdfDetach', function () {
describe('showPdfDetach=false', function () {
beforeEach(function () {
this.Features.hasFeature.withArgs('saas').returns(true)
})
it('should be false by default in SaaS', function (done) {
this.res.render = (pageName, opts) => {
expect(opts.showPdfDetach).to.be.false
done()
}
this.ProjectController.loadEditor(this.req, this.res)
})
it('should be true by default in Server Pro', function (done) {
this.Features.hasFeature.withArgs('saas').returns(false)
this.res.render = (pageName, opts) => {
expect(opts.showPdfDetach).to.be.true
done()
}
this.ProjectController.loadEditor(this.req, this.res)
})
it('should be false when the split test is enabled and ?pdf_detach=false', function (done) {
this.res.render = (pageName, opts) => {
expect(opts.showPdfDetach).to.be.false
done()
}
this.SplitTestHandler.getAssignment
.withArgs(this.req, this.res, 'pdf-detach')
.yields(null, { variant: 'enabled' })
this.req.query.pdf_detach = 'false'
this.ProjectController.loadEditor(this.req, this.res)
})
})
describe('showPdfDetach=true', function () {
it('should be true when ?pdf_detach=true', function (done) {
this.res.render = (pageName, opts) => {
expect(opts.showPdfDetach).to.be.true
done()
}
this.req.query.pdf_detach = 'true'
this.ProjectController.loadEditor(this.req, this.res)
})
it('should be true for alpha group', function (done) {
this.res.render = (pageName, opts) => {
expect(opts.showPdfDetach).to.be.true
done()
}
this.SplitTestHandler.getAssignment
.withArgs(this.req, this.res, 'pdf-detach')
.yields(null, { variant: 'enabled' })
this.ProjectController.loadEditor(this.req, this.res)
})
})
})
})
describe('upgrade prompt (on header and share project modal)', function () {
beforeEach(function () {
// default to saas enabled