Merge pull request #16385 from overleaf/em-typescript-other-services

Add type checking to all services

GitOrigin-RevId: f328a811fca7a783e9aff7d015ea73756acededd

services/chat/Makefile

@@ -45,7 +45,10 @@ lint:
 lint_fix:
 	$(RUN_LINTING) lint:fix
 
-test: format lint test_unit test_acceptance
+typecheck:
+	$(RUN_LINTING) typecheck
+
+test: format lint typecheck test_unit test_acceptance
 
 test_unit:
 ifneq (,$(wildcard test/unit))

services/chat/package.json

@@ -14,7 +14,8 @@
     "lint": "eslint --max-warnings 0 --format unix .",
     "format": "prettier --list-different $PWD/'**/*.js'",
     "format:fix": "prettier --write $PWD/'**/*.js'",
-    "lint:fix": "eslint --fix ."
+    "lint:fix": "eslint --fix .",
+    "typecheck": "tsc --noEmit"
   },
   "dependencies": {
     "@overleaf/logger": "*",
@@ -35,7 +36,8 @@
     "request": "^2.88.2",
     "sandboxed-module": "^2.0.4",
     "sinon": "^9.2.4",
-    "timekeeper": "^2.2.0"
+    "timekeeper": "^2.2.0",
+    "typescript": "^5.0.4"
   },
   "version": "1.0.0",
   "directories": {

services/chat/tsconfig.json

@@ -0,0 +1,9 @@
+{
+  "extends": "../../tsconfig.backend.json",
+  "include": [
+    "app.js",
+    "app/src/**/*",
+    "scripts/**/*",
+    "test/**/*"
+  ]
+}