From e773db99507610d5425bf85a1db4660fe1d06c69 Mon Sep 17 00:00:00 2001
From: Jessica Lawshe <5312836+lawshe@users.noreply.github.com>
Date: Wed, 8 Mar 2023 08:42:51 -0600
Subject: [PATCH] Merge pull request #11996 from
 overleaf/jel-pdf-detach-download

[web] Add download attribute to download button in file view

GitOrigin-RevId: 7fdbd970d87bd3678863f23be993a34140a5726b
---
 .../components/file-tree-item/file-tree-item-menu-items.js    | 4 +++-
 .../js/features/file-view/components/file-view-header.js      | 1 +
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/services/web/frontend/js/features/file-tree/components/file-tree-item/file-tree-item-menu-items.js b/services/web/frontend/js/features/file-tree/components/file-tree-item/file-tree-item-menu-items.js
index a439291cea..fe70283890 100644
--- a/services/web/frontend/js/features/file-tree/components/file-tree-item/file-tree-item-menu-items.js
+++ b/services/web/frontend/js/features/file-tree/components/file-tree-item/file-tree-item-menu-items.js
@@ -24,7 +24,9 @@ function FileTreeItemMenuItems() {
         <MenuItem onClick={startRenaming}>{t('rename')}</MenuItem>
       ) : null}
       {downloadPath ? (
-        <MenuItem href={downloadPath}>{t('download')}</MenuItem>
+        <MenuItem href={downloadPath} download>
+          {t('download')}
+        </MenuItem>
       ) : null}
       {canDelete ? (
         <MenuItem onClick={startDeleting}>{t('delete')}</MenuItem>
diff --git a/services/web/frontend/js/features/file-view/components/file-view-header.js b/services/web/frontend/js/features/file-view/components/file-view-header.js
index 2fa4dca157..154860390e 100644
--- a/services/web/frontend/js/features/file-view/components/file-view-header.js
+++ b/services/web/frontend/js/features/file-view/components/file-view-header.js
@@ -127,6 +127,7 @@ export default function FileViewHeader({ file, storeReferencesKeys }) {
       )}
       &nbsp;
       <a
+        download
         href={`/project/${projectId}/file/${file.id}`}
         className="btn btn-secondary-info btn-secondary"
       >