From 3a3933dfe90a5bcff65df5194f54497db0d923e4 Mon Sep 17 00:00:00 2001 From: James Allen Date: Mon, 28 Jul 2014 16:23:46 +0100 Subject: [PATCH 1/2] Don't immediately close context menu in Firefox --- .../directives/aceEditor/spell-check/SpellCheckManager.coffee | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/services/web/public/coffee/ide/editor/directives/aceEditor/spell-check/SpellCheckManager.coffee b/services/web/public/coffee/ide/editor/directives/aceEditor/spell-check/SpellCheckManager.coffee index 99c3da3662..adaedd458f 100644 --- a/services/web/public/coffee/ide/editor/directives/aceEditor/spell-check/SpellCheckManager.coffee +++ b/services/web/public/coffee/ide/editor/directives/aceEditor/spell-check/SpellCheckManager.coffee @@ -29,7 +29,8 @@ define [ @openContextMenu(e.domEvent) $(document).on "click", (e) => - @closeContextMenu(e) + if e.which != 3 # Ignore if this was a right click + @closeContextMenu(e) return true @$scope.replaceWord = (highlight, suggestion) => From 9db2fc93a4c7983bdd3402178865dd09ad2a012a Mon Sep 17 00:00:00 2001 From: James Allen Date: Mon, 28 Jul 2014 16:28:01 +0100 Subject: [PATCH 2/2] Add spell check underline to front marker layer --- .../aceEditor/spell-check/HighlightedWordManager.coffee | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/web/public/coffee/ide/editor/directives/aceEditor/spell-check/HighlightedWordManager.coffee b/services/web/public/coffee/ide/editor/directives/aceEditor/spell-check/HighlightedWordManager.coffee index 090086c8aa..2f70e44cee 100644 --- a/services/web/public/coffee/ide/editor/directives/aceEditor/spell-check/HighlightedWordManager.coffee +++ b/services/web/public/coffee/ide/editor/directives/aceEditor/spell-check/HighlightedWordManager.coffee @@ -21,7 +21,7 @@ define [ highlight.row, highlight.column, highlight.row, highlight.column + highlight.word.length ) - highlight.markerId = @editor.getSession().addMarker range, "spelling-highlight" + highlight.markerId = @editor.getSession().addMarker range, "spelling-highlight", null, true @highlights.rows[highlight.row] ||= [] @highlights.rows[highlight.row].push highlight