Merge pull request #36408 from overleaf/mj-context-menu-flag-teardown

[web] Tear down editor-context-menu flag

GitOrigin-RevId: 80cc2ebaf62ec1bd6064b0f96b884d159a9d4b5f

services/web/frontend/js/features/source-editor/extensions/context-menu.ts

@@ -396,8 +396,8 @@ const contextMenuKeymap = (): Extension =>
     ])
   )
 
-export const contextMenu = (enabled: boolean): Extension =>
-  enabled && !isMobile
+export const contextMenu = (): Extension =>
+  !isMobile
     ? [
         contextMenuContainerTheme,
         contextMenuStateField,

services/web/frontend/js/features/source-editor/extensions/index.ts

@@ -159,11 +159,8 @@ export const createExtensions = (options: Record<string, any>): Extension[] => [
   trackDetachedComments(options.currentDoc),
   visual(options.docName, options.visual),
   mathPreview(options.settings.mathPreview),
-  reviewTooltip(
-    options.settings.floatingMenu,
-    options.editorContextMenuEnabled
-  ),
-  contextMenu(options.editorContextMenuEnabled),
+  reviewTooltip(options.settings.floatingMenu),
+  contextMenu(),
   toolbarPanel(),
   breadcrumbPanel(),
   verticalOverflow(),

services/web/frontend/js/features/source-editor/extensions/review-tooltip.ts

@@ -32,28 +32,20 @@ const mouseDownStateField = StateField.define<boolean>({
 
 const reviewTooltipCompartment = new Compartment()
 
-export const reviewTooltip = (
-  enabled: boolean,
-  editorContextMenuEnabled: boolean = false
-): Extension => {
+export const reviewTooltip = (enabled: boolean): Extension => {
   return [
     addCommentRangesField,
-    reviewTooltipCompartment.of(
-      enabled ? reviewTooltipMenu(editorContextMenuEnabled) : []
-    ),
+    reviewTooltipCompartment.of(enabled ? reviewTooltipMenu() : []),
   ]
 }
 
-export const setReviewTooltip = (
-  enabled: boolean,
-  editorContextMenuEnabled: boolean
-): TransactionSpec => ({
+export const setReviewTooltip = (enabled: boolean): TransactionSpec => ({
   effects: reviewTooltipCompartment.reconfigure(
-    enabled ? reviewTooltipMenu(editorContextMenuEnabled) : []
+    enabled ? reviewTooltipMenu() : []
   ),
 })
 
-const reviewTooltipMenu = (editorContextMenuEnabled: boolean): Extension => {
+const reviewTooltipMenu = (): Extension => {
   let mouseUpListener: null | (() => void) = null
   const disableMouseUpListener = () => {
     if (mouseUpListener) {
@@ -68,7 +60,7 @@ const reviewTooltipMenu = (editorContextMenuEnabled: boolean): Extension => {
     EditorView.domEventHandlers({
       mousedown: (event, view) => {
         // Hide tooltip when opening the context menu
-        if (editorContextMenuEnabled && isContextMenuMouseEvent(event)) {
+        if (isContextMenuMouseEvent(event)) {
           return false
         }