agw/overleaf-cep
1
0
Fork 0
mirror of https://github.com/yu-i-i/overleaf-cep.git synced 2026-11-14 22:23:42 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #26395 from overleaf/as-compile-timeout-event-fix

Browse Source 
[web] Rename time segmentation value to compileTime to prevent MixPanel errors

GitOrigin-RevId: 70ddfd5091e3f8d98849f09dc9d09adc8c0bf2c7
This commit is contained in:
MoxAmber
2025-06-13 08:07:48 +00:00
committed by Copybot
parent 227f035c2e
commit e95b159edd
3 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/web/frontend/js/features/pdf-preview/components/compile-time-warning-upgrade-prompt.tsx
+6 -6
View File
@@ -29,7 +29,7 @@ function CompileTimeWarningUpgradePrompt() {
const warningSegmentation = useMemo( const warningSegmentation = useMemo(
() => ({ () => ({
content: 'warning', content: 'warning',
time: warningThreshold, compileTime: warningThreshold,
...sharedSegmentation, ...sharedSegmentation,
}), }),
[sharedSegmentation, warningThreshold] [sharedSegmentation, warningThreshold]
@@ -38,7 +38,7 @@ function CompileTimeWarningUpgradePrompt() {
const changingSoonSegmentation = useMemo( const changingSoonSegmentation = useMemo(
() => ({ () => ({
content: 'changes', content: 'changes',
time: 10, compileTime: 10,
...sharedSegmentation, ...sharedSegmentation,
}), }),
[sharedSegmentation] [sharedSegmentation]
@@ -58,7 +58,7 @@ function CompileTimeWarningUpgradePrompt() {
) { ) {
setShowWarning(true) setShowWarning(true)
eventTracking.sendMB('compile-time-warning-displayed', { eventTracking.sendMB('compile-time-warning-displayed', {
time: warningThreshold, compileTime: warningThreshold,
isProjectOwner, isProjectOwner,
}) })
} }
@@ -75,13 +75,13 @@ function CompileTimeWarningUpgradePrompt() {
const handleDismissWarning = useCallback(() => { const handleDismissWarning = useCallback(() => {
eventTracking.sendMB('compile-time-warning-dismissed', { eventTracking.sendMB('compile-time-warning-dismissed', {
time: warningThreshold, compileTime: warningThreshold,
isProjectOwner, isProjectOwner,
}) })
eventTracking.sendMB('paywall-dismiss', { eventTracking.sendMB('paywall-dismiss', {
'paywall-type': 'compile-time-warning', 'paywall-type': 'compile-time-warning',
content: 'warning', content: 'warning',
time: warningThreshold, compileTime: warningThreshold,
...sharedSegmentation, ...sharedSegmentation,
}) })
setShowWarning(false) setShowWarning(false)
@@ -98,7 +98,7 @@ function CompileTimeWarningUpgradePrompt() {
const handleDismissChangingSoon = useCallback(() => { const handleDismissChangingSoon = useCallback(() => {
eventTracking.sendMB('paywall-dismiss', { eventTracking.sendMB('paywall-dismiss', {
'paywall-type': 'compile-time-warning', 'paywall-type': 'compile-time-warning',
time: 10, compileTime: 10,
content: 'changes', content: 'changes',
...sharedSegmentation, ...sharedSegmentation,
}) })
services/web/frontend/js/features/pdf-preview/components/timeout-upgrade-paywall-prompt.tsx
+1 -1
View File
@@ -39,7 +39,7 @@ function TimeoutUpgradePaywallPrompt({
() => ({ () => ({
'10s-timeout-warning': reducedTimeoutWarning, '10s-timeout-warning': reducedTimeoutWarning,
'is-owner': isProjectOwner, 'is-owner': isProjectOwner,
time: compileTimeout, compileTime: compileTimeout,
}), }),
[isProjectOwner, reducedTimeoutWarning, compileTimeout] [isProjectOwner, reducedTimeoutWarning, compileTimeout]
) )
services/web/frontend/js/features/pdf-preview/components/timeout-upgrade-prompt-new.tsx
+1 -1
View File
@@ -33,7 +33,7 @@ function TimeoutUpgradePromptNew() {
() => ({ () => ({
'10s-timeout-warning': reducedTimeoutWarning, '10s-timeout-warning': reducedTimeoutWarning,
'is-owner': isProjectOwner, 'is-owner': isProjectOwner,
time: compileTimeout, compileTime: compileTimeout,
}), }),
[isProjectOwner, reducedTimeoutWarning, compileTimeout] [isProjectOwner, reducedTimeoutWarning, compileTimeout]
) )