From e9dbaf20b812b60f88b87ba6817364c0ec93c3ff Mon Sep 17 00:00:00 2001 From: Alf Eaton Date: Fri, 9 Feb 2024 09:17:47 +0000 Subject: [PATCH] Wrap useResizeObserver dependency in useCallback (#16972) GitOrigin-RevId: fd4a10a2897878361a87bb02c5c6e8e6abfa8f26 --- .../components/pdf-log-entry-raw-content.jsx | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/services/web/frontend/js/features/pdf-preview/components/pdf-log-entry-raw-content.jsx b/services/web/frontend/js/features/pdf-preview/components/pdf-log-entry-raw-content.jsx index d1457d5586..ed4b6db34a 100644 --- a/services/web/frontend/js/features/pdf-preview/components/pdf-log-entry-raw-content.jsx +++ b/services/web/frontend/js/features/pdf-preview/components/pdf-log-entry-raw-content.jsx @@ -1,4 +1,4 @@ -import { useState } from 'react' +import { useCallback, useState } from 'react' import { useResizeObserver } from '../../../shared/hooks/use-resize-observer' import { useTranslation } from 'react-i18next' import classNames from 'classnames' @@ -13,9 +13,14 @@ export default function PdfLogEntryRawContent({ const [expanded, setExpanded] = useState(false) const [needsExpander, setNeedsExpander] = useState(false) - const { elementRef } = useResizeObserver(element => { - setNeedsExpander(element.scrollHeight > collapsedSize) - }) + const { elementRef } = useResizeObserver( + useCallback( + element => { + setNeedsExpander(element.scrollHeight > collapsedSize) + }, + [collapsedSize] + ) + ) const { t } = useTranslation()