From ea59a983864d48e6d02092286417058760b0bc2a Mon Sep 17 00:00:00 2001 From: Tyna William <65050204+tynawilliam@users.noreply.github.com> Date: Tue, 13 Jun 2023 11:45:14 -0400 Subject: [PATCH] Merge pull request #13473 from overleaf/revert-13439-tw-support-rnw-files Revert "support for Rnw files" GitOrigin-RevId: 1116814958cabed4c741bd0d3cce7670a6ca5ed4 --- services/clsi/app/js/LatexRunner.js | 2 +- services/clsi/test/acceptance/js/helpers/Client.js | 1 - services/web/app/src/Features/Project/ProjectRootDocManager.js | 2 +- services/web/config/settings.defaults.js | 2 +- services/web/cypress/support/ct/window.ts | 2 +- services/web/frontend/stories/decorators/scope.tsx | 2 +- 6 files changed, 5 insertions(+), 6 deletions(-) diff --git a/services/clsi/app/js/LatexRunner.js b/services/clsi/app/js/LatexRunner.js index 51286dce91..55769ec2f3 100644 --- a/services/clsi/app/js/LatexRunner.js +++ b/services/clsi/app/js/LatexRunner.js @@ -184,7 +184,7 @@ function _buildLatexCommand(mainFile, opts = {}) { // We want to run latexmk on the tex file which we will automatically // generate from the Rtex/Rmd/md file. - mainFile = mainFile.replace(/\.(Rtex|md|Rmd|Rnw)$/, '.tex') + mainFile = mainFile.replace(/\.(Rtex|md|Rmd)$/, '.tex') command.push(Path.join('$COMPILE_DIR', mainFile)) return command diff --git a/services/clsi/test/acceptance/js/helpers/Client.js b/services/clsi/test/acceptance/js/helpers/Client.js index 041518966d..88ed4d3be5 100644 --- a/services/clsi/test/acceptance/js/helpers/Client.js +++ b/services/clsi/test/acceptance/js/helpers/Client.js @@ -178,7 +178,6 @@ module.exports = Client = { 'ist', 'md', 'Rmd', - 'Rnw', ].indexOf(extension) > -1 ) { resources.push({ diff --git a/services/web/app/src/Features/Project/ProjectRootDocManager.js b/services/web/app/src/Features/Project/ProjectRootDocManager.js index c1779fee58..c7aceb6f4d 100644 --- a/services/web/app/src/Features/Project/ProjectRootDocManager.js +++ b/services/web/app/src/Features/Project/ProjectRootDocManager.js @@ -72,7 +72,7 @@ module.exports = ProjectRootDocManager = { if (callback == null) { callback = function () {} } - const filePathsPromise = globby(['**/*.{tex,Rtex,Rnw}'], { + const filePathsPromise = globby(['**/*.{tex,Rtex}'], { cwd: directoryPath, followSymlinkedDirectories: false, onlyFiles: true, diff --git a/services/web/config/settings.defaults.js b/services/web/config/settings.defaults.js index 24f44bb8d7..c7174f6239 100644 --- a/services/web/config/settings.defaults.js +++ b/services/web/config/settings.defaults.js @@ -674,7 +674,7 @@ module.exports = { process.env.FILE_IGNORE_PATTERN || '**/{{__MACOSX,.git,.texpadtmp,.R}{,/**},.!(latexmkrc),*.{dvi,aux,log,toc,out,pdfsync,synctex,synctex(busy),fdb_latexmk,fls,nlo,ind,glo,gls,glg,bbl,blg,doc,docx,gz,swp}}', - validRootDocExtensions: ['tex', 'Rtex', 'ltx', 'Rnw'], + validRootDocExtensions: ['tex', 'Rtex', 'ltx'], emailConfirmationDisabled: process.env.EMAIL_CONFIRMATION_DISABLED === 'true' || false, diff --git a/services/web/cypress/support/ct/window.ts b/services/web/cypress/support/ct/window.ts index 6a2529d2c9..dec1aa788f 100644 --- a/services/web/cypress/support/ct/window.ts +++ b/services/web/cypress/support/ct/window.ts @@ -1,5 +1,5 @@ window.i18n = { currentLangCode: 'en' } window.ExposedSettings = { appName: 'Overleaf', - validRootDocExtensions: ['tex', 'Rtex', 'ltx', 'Rnw'], + validRootDocExtensions: ['tex', 'Rtex', 'ltx'], } as typeof window.ExposedSettings diff --git a/services/web/frontend/stories/decorators/scope.tsx b/services/web/frontend/stories/decorators/scope.tsx index 3d0696eeb8..2bbf058eee 100644 --- a/services/web/frontend/stories/decorators/scope.tsx +++ b/services/web/frontend/stories/decorators/scope.tsx @@ -184,7 +184,7 @@ const initialize = () => { 'gv', 'mf', ], - validRootDocExtensions: ['tex', 'Rtex', 'ltx', 'Rnw'], + validRootDocExtensions: ['tex', 'Rtex', 'ltx'], } window.project_id = project._id