From eb9044bc9be260730deb8bc869c3a0661c25e0b6 Mon Sep 17 00:00:00 2001 From: David <33458145+davidmcpowell@users.noreply.github.com> Date: Mon, 10 Jun 2024 09:46:26 +0100 Subject: [PATCH] Merge pull request #18806 from overleaf/dp-revert-18445 Remove workaround for chrome pdf rendering bug that has since been fixed GitOrigin-RevId: 622f04d6dad848dc725e0f1776ea37436a60dc63 --- .../pdf-preview/components/pdf-js-viewer.tsx | 30 ------------------- 1 file changed, 30 deletions(-) diff --git a/services/web/frontend/js/features/pdf-preview/components/pdf-js-viewer.tsx b/services/web/frontend/js/features/pdf-preview/components/pdf-js-viewer.tsx index 4e955d91a7..14925739a3 100644 --- a/services/web/frontend/js/features/pdf-preview/components/pdf-js-viewer.tsx +++ b/services/web/frontend/js/features/pdf-preview/components/pdf-js-viewer.tsx @@ -461,36 +461,6 @@ function PdfJsViewer({ url, pdfFile }: PdfJsViewerProps) { [initialised, setZoom] ) - /** - * Work around an issue in Chrome 125 that causes canvas elements to become blank - * when a tab is inactive, by making the canvas redraw when the tab becomes active. - * https://github.com/mozilla/pdf.js/issues/18100 - * https://issues.chromium.org/issues/339654395 - * This can be removed once Chrome 127 is widely available. - */ - useEffect(() => { - const listener = () => { - if (document.visibilityState !== 'hidden' && pdfJsWrapper) { - window.setTimeout(() => { - for (const canvas of pdfJsWrapper.container.querySelectorAll( - 'canvas' - )) { - canvas.style.display = 'none' - window.setTimeout(() => { - canvas.style.display = 'block' - }, 1) - } - }, 100) - } - } - - document.addEventListener('visibilitychange', listener) - - return () => { - document.removeEventListener('visibilitychange', listener) - } - }, [pdfJsWrapper]) - // Don't render the toolbar until we have the necessary information const toolbarInfoLoaded = rawScale !== null && page !== null && totalPages !== null