From ee2efc349550ff9cde220d299af26f9e325e9e50 Mon Sep 17 00:00:00 2001 From: Christopher Hoskin Date: Thu, 17 Apr 2025 10:31:11 +0100 Subject: [PATCH] Merge pull request #24971 from overleaf/csh-issue-19131-diable-filestore-endpoints Disable the old filestore endpoints if user_files not defined GitOrigin-RevId: f7d188cef3fe53835070903448690baff4ebad98 --- services/filestore/app.js | 74 ++++++++++++++++++++------------------- 1 file changed, 38 insertions(+), 36 deletions(-) diff --git a/services/filestore/app.js b/services/filestore/app.js index 7b5de3003f..24741e079c 100644 --- a/services/filestore/app.js +++ b/services/filestore/app.js @@ -50,43 +50,45 @@ app.use((req, res, next) => { Metrics.injectMetricsRoute(app) -app.head( - '/project/:project_id/file/:file_id', - keyBuilder.userFileKeyMiddleware, - fileController.getFileHead -) -app.get( - '/project/:project_id/file/:file_id', - keyBuilder.userFileKeyMiddleware, - fileController.getFile -) -app.post( - '/project/:project_id/file/:file_id', - keyBuilder.userFileKeyMiddleware, - fileController.insertFile -) -app.put( - '/project/:project_id/file/:file_id', - keyBuilder.userFileKeyMiddleware, - bodyParser.json(), - fileController.copyFile -) -app.delete( - '/project/:project_id/file/:file_id', - keyBuilder.userFileKeyMiddleware, - fileController.deleteFile -) -app.delete( - '/project/:project_id', - keyBuilder.userProjectKeyMiddleware, - fileController.deleteProject -) +if (settings.filestore.stores.user_files) { + app.head( + '/project/:project_id/file/:file_id', + keyBuilder.userFileKeyMiddleware, + fileController.getFileHead + ) + app.get( + '/project/:project_id/file/:file_id', + keyBuilder.userFileKeyMiddleware, + fileController.getFile + ) + app.post( + '/project/:project_id/file/:file_id', + keyBuilder.userFileKeyMiddleware, + fileController.insertFile + ) + app.put( + '/project/:project_id/file/:file_id', + keyBuilder.userFileKeyMiddleware, + bodyParser.json(), + fileController.copyFile + ) + app.delete( + '/project/:project_id/file/:file_id', + keyBuilder.userFileKeyMiddleware, + fileController.deleteFile + ) + app.delete( + '/project/:project_id', + keyBuilder.userProjectKeyMiddleware, + fileController.deleteProject + ) -app.get( - '/project/:project_id/size', - keyBuilder.userProjectKeyMiddleware, - fileController.directorySize -) + app.get( + '/project/:project_id/size', + keyBuilder.userProjectKeyMiddleware, + fileController.directorySize + ) +} if (settings.filestore.stores.template_files) { app.head(