agw/overleaf-cep
1
0
Fork 0
mirror of https://github.com/yu-i-i/overleaf-cep.git synced 2026-11-14 14:13:43 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #33172 from overleaf/bg-fix-project-upload-unlinks

Browse Source 
fix: use fsPromises ins ProjectUploadController async functions for consistency
GitOrigin-RevId: beb858d9b6cf50431fb14626dfd7cddfaf093882
This commit is contained in:
Brian Gough
2026-05-01 08:05:52 +00:00
committed by Copybot
parent 970bc85b78
commit eec3be362b
2 changed files with 40 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/web/test/unit/src/Uploads/ProjectUploadController.test.mjs
+22 -4
View File
@@ -112,7 +112,7 @@ describe('ProjectUploadController', function () {
})
)
vi.doMock('fs', () => ({
vi.doMock('node:fs', () => ({
default: (ctx.fs = {}),
}))
@@ -141,6 +141,7 @@ describe('ProjectUploadController', function () {
ctx.project = { _id: (ctx.project_id = 'project-id-123') }
ctx.fs.unlink = sinon.stub()
ctx.fsPromises.unlink = sinon.stub().resolves()
})
describe('successfully', function () {
@@ -200,6 +201,10 @@ describe('ProjectUploadController', function () {
JSON.stringify({ success: false, error: 'upload_failed' })
)
})
it('should remove the uploaded file', function (ctx) {
ctx.fs.unlink.calledWith(ctx.path).should.equal(true)
})
})
describe('when ProjectUploadManager.createProjectFromZipArchive reports the file as invalid', function () {
@@ -224,6 +229,10 @@ describe('ProjectUploadController', function () {
it("should return an 'unprocessable entity' status code", function (ctx) {
expect(ctx.res.statusCode).to.equal(422)
})
it('should remove the uploaded file', function (ctx) {
ctx.fs.unlink.calledWith(ctx.path).should.equal(true)
})
})
})
@@ -247,6 +256,7 @@ describe('ProjectUploadController', function () {
ctx.req.params = { Project_id: ctx.project_id }
ctx.req.query = { folder_id: ctx.folder_id }
ctx.fs.unlink = sinon.stub()
ctx.fsPromises.unlink = sinon.stub().resolves()
})
describe('successfully', function () {
@@ -361,7 +371,7 @@ describe('ProjectUploadController', function () {
})
it('should unlink the file', function (ctx) {
ctx.fs.unlink.should.have.been.calledWith(ctx.path)
ctx.fsPromises.unlink.should.have.been.calledWith(ctx.path)
})
it('should call next with the error', function (ctx) {
@@ -384,6 +394,10 @@ describe('ProjectUploadController', function () {
})
)
})
it('should remove the uploaded file', function (ctx) {
ctx.fs.unlink.calledWith(ctx.path).should.equal(true)
})
})
describe('when FileSystemImportManager.addEntity returns a too many files error', function () {
@@ -402,6 +416,10 @@ describe('ProjectUploadController', function () {
})
)
})
it('should remove the uploaded file', function (ctx) {
ctx.fs.unlink.calledWith(ctx.path).should.equal(true)
})
})
describe('with an invalid filename', function () {
@@ -420,7 +438,7 @@ describe('ProjectUploadController', function () {
})
it('should remove the uploaded file', function (ctx) {
ctx.fs.unlink.calledWith(ctx.path).should.equal(true)
ctx.fsPromises.unlink.calledWith(ctx.path).should.equal(true)
})
})
@@ -440,7 +458,7 @@ describe('ProjectUploadController', function () {
})
it('should remove the uploaded file', function (ctx) {
ctx.fs.unlink.calledWith(ctx.path).should.equal(true)
ctx.fsPromises.unlink.calledWith(ctx.path).should.equal(true)
})
})
})