From eefe56d0f77c40a0b794ea6b9e8de1687c071ae8 Mon Sep 17 00:00:00 2001 From: Shane Kilkelly Date: Fri, 8 Dec 2017 11:37:24 +0000 Subject: [PATCH] Fix up error handling in SubscriptionUpdater --- .../coffee/Features/Subscription/SubscriptionUpdater.coffee | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/services/web/app/coffee/Features/Subscription/SubscriptionUpdater.coffee b/services/web/app/coffee/Features/Subscription/SubscriptionUpdater.coffee index 9b5fe83f88..d3b1a0feb7 100644 --- a/services/web/app/coffee/Features/Subscription/SubscriptionUpdater.coffee +++ b/services/web/app/coffee/Features/Subscription/SubscriptionUpdater.coffee @@ -112,10 +112,11 @@ module.exports = SubscriptionUpdater = overleafPlanCode: (cb) -> Modules = require '../../infrastructure/Modules' Modules.hooks.fire 'getOverleafPlanCode', user_id, (err, results) -> - cb(err, results[0]) + cb(err, results?[0] || null) async.series jobs, (err, results)-> if err? - logger.err err:err, user_id:user, "error getting subscription or group for _setUsersMinimumFeatures" + logger.err err:err, user_id:user_id, + "error getting subscription or group for _setUsersMinimumFeatures" return callback(err) {subscription, groupSubscription, overleafPlanCode} = results # Group Subscription