From ef5ed876a415fdfbcadd221a20345428b8dee86b Mon Sep 17 00:00:00 2001 From: Brian Gough Date: Fri, 10 Nov 2023 13:40:13 +0000 Subject: [PATCH] Merge pull request #15716 from overleaf/bg-eslint-console-log-in-web-tests add console.log rule for tests in web eslintrc GitOrigin-RevId: 166135e379309870fa4fe2d1797cb4c93cf2d877 --- services/web/.eslintrc | 4 +++- services/web/test/acceptance/getModuleTargets.js | 1 + services/web/test/acceptance/src/ConvertArchivedState.js | 4 +--- services/web/test/unit/src/User/SAMLIdentityManagerTests.js | 1 - 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/services/web/.eslintrc b/services/web/.eslintrc index 4d7c76e5c0..a6e9dafabb 100644 --- a/services/web/.eslintrc +++ b/services/web/.eslintrc @@ -299,7 +299,9 @@ "**/app/**/*.{js,cjs,mjs}", "app.js", "modules/*/*.js", // Frontend: Prefer debugConsole over bare console // Docs: https://manual.dev-overleaf.com/development/code/logging/#frontend - "**/frontend/**/*.{js,jsx,ts,tsx}" + "**/frontend/**/*.{js,jsx,ts,tsx}", + // Tests + "**/test/**/*.{js,cjs,mjs,jsx,ts,tsx}" ], "excludedFiles": [ // Allow console logs in scripts diff --git a/services/web/test/acceptance/getModuleTargets.js b/services/web/test/acceptance/getModuleTargets.js index 2e5d97302f..8e12482851 100644 --- a/services/web/test/acceptance/getModuleTargets.js +++ b/services/web/test/acceptance/getModuleTargets.js @@ -1,3 +1,4 @@ +/* eslint-disable no-console */ // silence settings module console.log = function () {} const Settings = require('@overleaf/settings') diff --git a/services/web/test/acceptance/src/ConvertArchivedState.js b/services/web/test/acceptance/src/ConvertArchivedState.js index c2926f093d..12b79349ac 100644 --- a/services/web/test/acceptance/src/ConvertArchivedState.js +++ b/services/web/test/acceptance/src/ConvertArchivedState.js @@ -118,10 +118,8 @@ describe('ConvertArchivedState', function () { beforeEach(function (done) { exec( 'CONNECT_DELAY=1 node scripts/convert_archived_state.js FIRST,SECOND', - (error, stdout, stderr) => { + error => { if (error) { - console.log(stdout) - console.error(stderr) return done(error) } done() diff --git a/services/web/test/unit/src/User/SAMLIdentityManagerTests.js b/services/web/test/unit/src/User/SAMLIdentityManagerTests.js index 7f56b19b1c..e6e1f1baaa 100644 --- a/services/web/test/unit/src/User/SAMLIdentityManagerTests.js +++ b/services/web/test/unit/src/User/SAMLIdentityManagerTests.js @@ -186,7 +186,6 @@ describe('SAMLIdentityManager', function () { error = e } finally { expect(error).to.exist - console.log(error) expect(error.message).to.contain( 'missing data when linking institution SSO' )